Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some document have non-standard locale code #1824

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

ernst77
Copy link

@ernst77 ernst77 commented Feb 16, 2020

Description

Some documents come with style locale as en_GB, en_US this fixes these locale codes

Fixes #

replaces "_" to "-"

Checklist:

  • [x ] I have run composer run-script check --timeout=0 and no errors were reported
  • [ x] The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 94.634% when pulling 37c15e6 on ErnestStaug:locale_support into 733f845 on PHPOffice:develop.

@troosan troosan added this to the v0.18.0 milestone Feb 7, 2021
@troosan troosan merged commit 5080139 into PHPOffice:develop Feb 7, 2021
@troosan troosan mentioned this pull request Feb 7, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants