feat: Update addHtml to handle style inheritance #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim is to get the output closer to the source html
|
There seems to be an issue with the .travis.yml file... Some kind of typo maybe but I'm no expert. Also, this pr relates to #1902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim is to get the output closer to the source html.
I noticed the issue in the doc file generated from HTML, in the table, a border was applied to the text inside the cells. Which was not right because no border was applied to the span. I understood that CSS inheritance of style properties was not taken into account by the parser so I decided to implement it.
Checklist:
composer run-script check --timeout=0and no errors were reported