Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process "font-variant: small-caps" when parsing HTML styles #2117

Closed
wants to merge 3 commits into from

Conversation

cambraca
Copy link
Contributor

@cambraca cambraca commented Jul 22, 2021

Description

When using Html::addHtml, the "font-variant" style wasn't being processed to recognize small caps.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

(I don't think there's anything to do in the docs).

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:15
@Progi1984
Copy link
Member

@cambraca Could you rebase your PR ? It's very interesting.

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Aug 30, 2023
@Progi1984 Progi1984 force-pushed the master branch 2 times, most recently from 6a60ae7 to 2d9f999 Compare August 30, 2023 10:14
@Progi1984
Copy link
Member

Progi1984 commented Aug 30, 2023

Fixed in e458249. Thanks @cambraca

@Progi1984 Progi1984 closed this Aug 30, 2023
@Progi1984 Progi1984 added this to the 1.2.0 milestone Aug 30, 2023
@Progi1984 Progi1984 reopened this Aug 30, 2023
@Progi1984 Progi1984 closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for feedback Question has been asked, waiting for response from PR author
Development

Successfully merging this pull request may close these issues.

2 participants