-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Image relative and absolute positioning #217
Conversation
Thanks @basjan. Yes, this is what we expected. Great enhancements. Your pull failed Travis build because PHPWord uses PSR coding standards. But don't worry. This can be fixed easily. I'll review and merge your pull this weekend. Whenever you have time, please read our contributing guideline. Thanks again for your contribution. Welcome to GitHub :) |
@ivanlanin Thank you very much. I am learning a lot new these few days. I have installed Eclipse as IDE with a PHP_Codesniffer plugin. However, it seems that somekind of ruleset needs to be used. Do you have any idea? |
I don't use Eclipse, but based on the screenshot I see from point number 2 on this page, you should check |
I could reproduce the Travis CI errors and have now setup Eclipse, such that the code is checked on PSR-2 standard. Thanks |
header in a section. This resulted in a corrupt DOCX
to the first header element. This resulted in a corrupted DOCX, when a media element was assigned to a second header in the same section.
Sorry @ivanlanin , it seems I am messing things up. I changed the bug in my 'develop' branch and committed this, but this is then apparently added to the already pending pull request. Again sorry for the mess up, and thanks for all the help you already provided. |
No problem. This page may help you to sync your fork. |
Hi @basjan. I've merged your code to the |
@ivanlanin and others: This is my first pull request.
I have added a small part of my amendments to the code, which @gabrielbull published under issue #209
The changes relate the absolute and relative positioning of images.
Would this be what you would expect from me ?
Regards