Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fixing #257 and helps out on #324 #416

Closed
wants to merge 1 commit into from

Conversation

twmobius
Copy link

I think this properly solves #257 replacing method_exists with is_callable as well as empty tables being generated.

@Progi1984
Copy link
Member

@twmobius Hi, could you

@twmobius
Copy link
Author

@Progi1984 I'll try and get that in the next couple of days.

@ugomeda It has been mentioned on #324 by @mogilvie that "The problem is that HTML elements <tbody> <tr> and <td> are not DOMElements as defined by the Abstract Container class. Because these HTML elements are not DOM Abstract Containers the parseChildNodes method doesnt check for any child elements." But at the same time the don't have the addText method, thus it need checking before calling

@Progi1984
Copy link
Member

@twmobius Some news ?

@ghost ghost removed the Pull Request label Mar 1, 2015
@garethellis36
Copy link
Contributor

If @twmobius no longer has time or motivation to fix this PR, does anyone object if I take his changes, add @Progi1984 's proposed fixes above and submit a fresh PR? I could really use the ability to add <table> HTML

@Progi1984
Copy link
Member

👍

@troosan
Copy link
Contributor

troosan commented Nov 7, 2017

closing as continued in #724

@troosan troosan closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants