Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature for columns in section, continuous section break, softbreak, hanging paragraph, and normal style #48

Closed
wants to merge 13 commits into from
Closed

Feature for columns in section, continuous section break, softbreak, hanging paragraph, and normal style #48

wants to merge 13 commits into from

Conversation

ivanlanin
Copy link
Contributor

Changes:

  • Section: Add column, spacing, and break type
  • Paragraph: Add hanging
  • TextRun: Add break (SHIFT + ENTER)
  • Style: Rewrite normal paragraph style and base all new style to that

Progi1984
Progi1984 reviewed Mar 5, 2014
View reviewed changes
Classes/PHPWord.php
@@ -39,6 +39,9 @@
class PHPWord
{

const DEFAULT_FONT_NAME = 'Times New Roman';
const DEFAULT_FONT_SIZE = 24;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you change default font ? Arial become Times New Roman & 20 become 24.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, my bad :) I forgot to set back my personal style to default setup. Will fix it.

@Progi1984
Copy link
Member

Could you update your branch with last updates ?
Could you point your pull request to the develop branch ( #79 ) ?
Could you add a sample (Sample_05_???) ?
Thanks :)

@ivanlanin
Copy link
Contributor Author

Ok. I will do it some time this week or on the weekend. Thanks.

@Progi1984
Copy link
Member

No, thanks to you :)

@ivanlanin
Copy link
Contributor Author

I withdraw this pull request to master branch and send a new one to develop branch.

@ivanlanin ivanlanin closed this Mar 6, 2014
@Progi1984
Copy link
Member

Next -> #86

@ivanlanin ivanlanin mentioned this pull request Apr 22, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanlanin @Progi1984