Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postprocessing of documents returned by Template class before moving to final destination #57

Merged
merged 1 commit into from Mar 3, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2014

#56

Postprocessing of documents returned by Template class before moving to final destination
@jdespatis
Copy link

@RomanSyroeshko For my interest, will it be possible to easily insert image into template, when this PR will be merged ?

Current workaround seems to be: https://phpword.codeplex.com/discussions/282759
but it needs patching

@ghost
Copy link
Author

ghost commented Jan 23, 2014

@jdespatis, the PR resolves the problem described in the issue and this is the only thing it resolves. "One issue - one problem" rule is a best practice. If you need something extra, please, raise another issue. PRs are also welcome.

By the way, the link you provided is broken (it shows empty discussion).

@Progi1984 Progi1984 added this to the 0.7.2 milestone Feb 25, 2014
@Progi1984 Progi1984 modified the milestones: 0.7.1, 0.7.2 Mar 3, 2014
Progi1984 added a commit that referenced this pull request Mar 3, 2014
Postprocessing of documents returned by Template class before moving to final destination
@Progi1984 Progi1984 merged commit cc61801 into PHPOffice:master Mar 3, 2014
@ghost ghost deleted the PHPWord#56 branch March 4, 2014 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants