Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken cell cache / incorrect rows deletion #868

Closed
AlexPravdin opened this issue Jan 31, 2019 · 2 comments
Closed

Broken cell cache / incorrect rows deletion #868

AlexPravdin opened this issue Jan 31, 2019 · 2 comments
Labels

Comments

@AlexPravdin
Copy link
Contributor

This is:

- [X] a bug report
<?php

require __DIR__ . '/vendor/autoload.php';

$workbook = new \PhpOffice\PhpSpreadsheet\Spreadsheet();
$sheet = $workbook->getActiveSheet();
$sheet->getCell('A3')->setValue('A3');
$sheet->getCell('C1')->setValue('C1');
$sheet->removeRow(1, 2);
echo $workbook->getActiveSheet()->getCell('A1')->getValue(), "\n";
echo $workbook->getActiveSheet()->getCell('C1')->getValue(), "\n";

What is the expected behavior?

Script should output

A3

Value C1 must be deleted within the row. Value A3 moved to the first row as previous rows were deleted.

What is the current behavior?

A3
C1

The C1 value remain while its row was deleted.

Which versions of PhpSpreadsheet and PHP are affected?

PhpSpreadsheet 1.6.0
PHP 7.3.1

@stale
Copy link

stale bot commented Apr 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Apr 1, 2019
@stale stale bot closed this as completed Apr 8, 2019
@AlexPravdin
Copy link
Contributor Author

Hey, what about PR for this issue?

PowerKiKi pushed a commit that referenced this issue Aug 12, 2019
PowerKiKi added a commit that referenced this issue Aug 17, 2019
1.9.0

### Added

- When &lt;br&gt; appears in a table cell, set the cell to wrap [#1071](#1071) and [#1070](#1070)
- Add MAXIFS, MINIFS, COUNTIFS and Remove MINIF, MAXIF [#1056](#1056)
- HLookup needs an ordered list even if range_lookup is set to false [#1055](#1055) and [#1076](#1076)
- Improve performance of IF function calls via ranch pruning to avoid resolution of every branches [#844](#844)
- MATCH function supports `*?~` Excel functionality, when match_type=0 [#1116](#1116)
- Allow HTML Reader to accept HTML as a string [#1136](#1136)

### Fixed

- Fix to AVERAGEIF() function when called with a third argument
- Eliminate duplicate fill none style entries [#1066](#1066)
- Fix number format masks containing literal (non-decimal point) dots [#1079](#1079)
- Fix number format masks containing named colours that were being misinterpreted as date formats; and add support for masks that fully replace the value with a full text string [#1009](#1009)
- Stricter-typed comparison testing in COUNTIF() and COUNTIFS() evaluation [#1046](#1046)
- COUPNUM should not return zero when settlement is in the last period [#1020](#1020) and [#1021](#1021)
- Fix handling of named ranges referencing sheets with spaces or "!" in their title
- Cover `getSheetByName()` with tests for name with quote and spaces [#739](#739)
- Best effort to support invalid colspan values in HTML reader - [#878](#878)
- Fixes incorrect rows deletion [#868](#868)
- MATCH function fix (value search by type, stop search when match_type=-1 and unordered element encountered) [#1116](#1116)
- Fix `getCalculatedValue()` error with more than two INDIRECT [#1115](#1115)
- Writer\Html did not hide columns [#985](#985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant