Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust to excel floor func behavior #1245

Closed
wants to merge 2 commits into from
Closed

adjust to excel floor func behavior #1245

wants to merge 2 commits into from

Conversation

eltociear
Copy link
Contributor

@eltociear eltociear commented Nov 17, 2019 •
edited
Loading

Excel FLOOR() function accept negative number and negative significance, but this function accept only positive significance.

- [ ] a bugfix

Checklist:

Why this change is needed?

PowerKiKi
PowerKiKi requested changes Nov 17, 2019
View reviewed changes
Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests must be adapted and completed in order to make Travis succeed.

@eltociear
Copy link
Contributor Author

thanks reply! and may be test case have mistake.

@PowerKiKi PowerKiKi closed this in cc92c66 Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PowerKiKi PowerKiKi PowerKiKi requested changes

Assignees
No one assigned
Labels
missing test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eltociear @PowerKiKi