ref #1325 Removed all '$' values from the auto filter range #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2020
|
@PowerKiKi Added test |
astronati
force-pushed
the
issues/1325
branch
from
0cca72e to
b6d0ad0
Compare
The `setRange` method of the `Xlsx/AutoFilter` class expects a filter range format like "A1:E10". The returned value from `$this->worksheetXml->autoFilter['ref']` could contain "$" and returning a value like "$A$1:$E$10". Fixes PHPOffice#687 Fixes PHPOffice#1325 Closes PHPOffice#1326
paulkned
pushed a commit
to paulkned/PhpSpreadsheet
that referenced
this pull request
Mar 6, 2020
The `setRange` method of the `Xlsx/AutoFilter` class expects a filter range format like "A1:E10". The returned value from `$this->worksheetXml->autoFilter['ref']` could contain "$" and returning a value like "$A$1:$E$10". Fixes PHPOffice#687 Fixes PHPOffice#1325 Closes PHPOffice#1326
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1325
This is:
What is the expected behavior?
The "$" character should be removed from the filter range.
What is the current behavior?
The
setRangemethod of theXlsx/AutoFilterclass expects a filter range format like "A1:E10".The returned value from
$this->worksheetXml->autoFilter['ref']could contain "$" and returning a value like "$A$1:$E$10".Which versions of PhpSpreadsheet and PHP are affected?
1.10.1