Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to get text & background color from inline css, for td & … #178

Closed
wants to merge 1 commit into from

Conversation

kifni41
Copy link
Contributor

@kifni41 kifni41 commented Jun 16, 2017

…th element

This is:

  • a bugfix
  • a new feature

Checklist:

What does it change?

I'm not sure if others need this feature, but this feature is quite handy for me and my team to directly generate excel file from html text, usually our client want specific coloring for the excel file and usually we already have the html for that.

This is limited for inline css inside and tag.

@PowerKiKi
Copy link
Member

This looks interesting. Would you have time to cover it with unit tests and fix the code style ?

@kifni41
Copy link
Contributor Author

kifni41 commented Jun 20, 2017

@PowerKiKi okay bro, i'll try,
I forgot to make new branch for this commit, should be on feature/ branch right?

@PowerKiKi
Copy link
Member

Yes, it would be best to be on its on branch, so you can keep pushing commits relating to that topic. But if you know what you are doing and only work on this topic, that coud be ok too...

@kifni41
Copy link
Contributor Author

kifni41 commented Jun 20, 2017

@PowerKiKi okay, created new branch for that. new PR submitted.
#180

@kifni41 kifni41 closed this Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants