allow to use customized pdf library #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerKiKi
requested changes
Oct 31, 2017
There was a problem hiding this comment.
Let's call that method createExternalWriterInstance instead of getExternalWriter.
The documentation should be updated to mentions this new feature, somewhere near docs/topics/reading-and-writing-to-file.md:830. As well as the CHANGELOG.md
And there are few minor comments above that should be fixed before merging.
| @@ -9,6 +9,18 @@ | |||
| class Dompdf extends Pdf implements IWriter | |||
| { | |||
| /** | |||
| * Gets the implementation of external PDF library that should be used. | |||
| * | |||
| * @param array $config Configuration array | |||
There was a problem hiding this comment.
There is no parameter named $config.
| * | ||
| * @param array $config Configuration array | ||
| * | ||
| * @return Dompdf implementation |
There was a problem hiding this comment.
This should be \Dompdf\Dompdf, not Dompdf
| * | ||
| * @param array $config Configuration array | ||
| * | ||
| * @return Mpdf implementation |
There was a problem hiding this comment.
This should be \Mpdf\Mpdf not Mpdf
|
done. But can you review my changes in docs/ and CHANGELOG.md? My English is not good for this kind of stuff :) |
PowerKiKi
approved these changes
Nov 4, 2017
|
Thanks ! |
Dfred
pushed a commit
to Dfred/PhpSpreadsheet
that referenced
this pull request
Nov 20, 2018
This allow to create and configure the standard instance of the external PDF libary, before returning it to the standard writer. Or, more powerful, this allow to provide a custom implementation of the external PDF library, allowing for custom behaviors. An example of that would something like: https://tcpdf.org/examples/example_003/ Closes PHPOffice#266
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
What does it change?
Allow to use customized PDF library without rewriting save() method.
Customized PDF libray sample: https://tcpdf.org/examples/example_003/