Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some work on refactoring the ReferenceHelper to extract the logic for updating cell references. #2682

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Mar 15, 2022

This is:

- [ ] a bugfix
- [ ] a new feature
- [X] refactoring

Checklist:

Why this change is needed?

Even absolute cell references ned updating in Conditional Formatting rules when new rows/columns are inserted; and the ReferenceHelper currently only updates relative references.

This is a preliminary step toward allowing updates to absolute cell references, required to update Conditional Formatting rules when columns/rows are inserted/deleted as highlighted by Issue #2678; the first step in a multi-step process.

  • Step 1
    Refactor the cell reference update logic to make it easier to modify, and to test the planned modifications
    This may also make the code more performant, as it allows elimination of a lot of code duplication in the different methods to update different components of the worksheet.

  • Step 2
    Modify the cell reference update logic to accept a flag indicating whether it should update absolute as well as relative cell references

  • Step 3
    Add the logic to update Conditional Formatting ranges and rules when inserting/deleting rows/columns

@MarkBaker MarkBaker force-pushed the Refactoring-Work-on-ReferenceHelper branch 6 times, most recently from 9db39ca to 6169233 Compare March 16, 2022 12:50
… updating cell references. This is a preliminary step toward allowing updates to absolute cell references, required to update Conditional Formatting rules.
@MarkBaker MarkBaker force-pushed the Refactoring-Work-on-ReferenceHelper branch 3 times, most recently from c68752d to 36d91aa Compare March 16, 2022 15:15
And a bugfix when deleting cells that contain hyperlinks (the hperlinks weren't being deleted, so were being "inherited" by whatever cell moved to that address)
@MarkBaker MarkBaker force-pushed the Refactoring-Work-on-ReferenceHelper branch from 36d91aa to bbe6b80 Compare March 16, 2022 15:38
@MarkBaker MarkBaker merged commit 251605f into master Mar 16, 2022
@MarkBaker MarkBaker deleted the Refactoring-Work-on-ReferenceHelper branch March 16, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant