Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files from composer package #4262

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jlherren
Copy link
Contributor

@jlherren jlherren commented Dec 4, 2024

These files make no sense to be distributed as part of the composer package.

If desired I can make the same change also for 1.x, where there are two additional files to be removed.

@oleibman
Copy link
Collaborator

oleibman commented Dec 4, 2024

Seems okay, but I need to read up on this. Should .readthedocs.yaml also be added to your list?

I don't know about earlier releases. I will give it some thought. What are the additional files you would like to exclude for release 1?

@jlherren
Copy link
Contributor Author

jlherren commented Dec 4, 2024

Version 1.29.5 also ships with:

  • phpstan-conditional.php
  • phpunit10.xml.dist

However, 3.5.0 does not ship with .readthedocs.yaml and I don't see why not, so perhaps there's more going on that just what's in .gitattributes.

@oleibman
Copy link
Collaborator

oleibman commented Dec 5, 2024

I need to resolve this question before I merge. When I run git archive on the current version, it includes .readthedocs.yaml. When I download the zip for release 3.5.0, it contains .readthedocs.yaml. When I do composer require phpoffice/phpspreadsheet, .readthedocs.yaml is part of it. Is there some other action that you can take which will download the release without that file?

@jlherren
Copy link
Contributor Author

jlherren commented Dec 5, 2024

My bad, I didn't realize that the screenshot was from 1.29.5, which in fact did not have .readthedocs.yml yet. I do get it on 3.5.0.

I updated the PR.

@oleibman oleibman added this pull request to the merge queue Dec 6, 2024
Merged via the queue into PHPOffice:master with commit e78ab77 Dec 6, 2024
13 checks passed
@oleibman
Copy link
Collaborator

oleibman commented Dec 6, 2024

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants