Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Context Options for https, Restore Disabled Tests #4276

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

oleibman
Copy link
Collaborator

Additional Context Options needed, at least sometimes, to read https images.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Additional Context Options needed, at least sometimes, to read https images.
Unacceptable performance.
@oleibman
Copy link
Collaborator Author

No idea what Scrutinizer's problem is today.

@lucasnetau
Copy link
Contributor

It's the keep-alive causing the 2m timeout. Try Connection:close instead, keep-alive isn't always required it's just what a browser would do.

I'd also recommend setting timeout setting for the http context to a lower value of say 10sec depending on your needs.

oleibman added a commit that referenced this pull request Dec 13, 2024
oleibman added a commit that referenced this pull request Dec 13, 2024
oleibman added a commit that referenced this pull request Dec 13, 2024
@oleibman oleibman added this pull request to the merge queue Dec 14, 2024
Merged via the queue into PHPOffice:master with commit eccbcce Dec 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants