-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add MegaLinter config files #1960
Conversation
I had a look through the checks. Some are quite strict, in a way that is actually quite helpful, but we wouldn't want to completely block code — for example:
In order to fully test it, we might want to open a branch on this repo — it's trying to do things like add comments to the PR, and failing because it's on a fork. We could get around that later by having it run on @eitsupi you should have permissions to push a branch to this repo. I don't see it making changes to Java code etc? For me, there are two helpful things from these:
One advantage of this was to run formatters on code we don't use much, like Java & C (and maybe something like python, which hardly exists in the repo). But maybe those don't actually have formatters? |
@max-sixty Thanks for taking a look at this.
So far only the linter corresponding to the fixes included in the PR is working.
While the ability exists for some linters or formatters to automatically correct, but auto-fixes are completely stopped to avoid conflicts with pre-commits CI. If we want MegaLinter to automatically fix your problem, we need to stop the pre-commit auto-fix.
We need to determine which Linter to disable, or to generate a warning but not treat it as an error..... |
@max-sixty Could you please tell me why pre-commit CI is failing in this PR? |
It's not permitted to fix workflow files by GitHub. (at the bottom it states "GitHub prevented pre-commit.ci from autofixing this pr due to autofixes to a workflow file") So we need to run locally and push the result. Lmk if you don't have it installed and I'm happy to do it |
The last commit made all files subject to Lint and found that it takes more than 5000 seconds (!) to check CSS.
Open another PR (#1974) and continue this. |
Close #1944