Add timings import test to the rss test suite #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farski
reviewed
Jun 25, 2024
| @@ -37,6 +37,29 @@ describe("Feeder RSS Import", () => { | |||
| cy.contains(".badge", "Complete", { timeout: 60000 }); | |||
| cy.contains("00:00:10"); | |||
|
|
|||
| // test timings import | |||
| const timingsFile = "cypress/samples/timings.csv"; | |||
There was a problem hiding this comment.
Given the nature of this data, I wonder if it would be worthwhile in this test to also test some invalid data to ensure that is handled as expected also.
There was a problem hiding this comment.
There is some error handling built into the timings importer ... I think if you just add a line to the CSV with a guid that doesn't exist in the database, you'll get an EpisodeImport in status = error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.