Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flexibility in data for use with Tax-Calculator #114

Merged
merged 21 commits into from
Jun 7, 2024

Conversation

jdebacker
Copy link
Member

This PR updates OG-USA to use the TMD datafile for Tax-Calculator -- and allows users to import a custom datafile with associated growth factors and weights.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.15%. Comparing base (29acbee) to head (60a8920).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   73.29%   73.15%   -0.14%     
==========================================
  Files          11       11              
  Lines         865      868       +3     
==========================================
+ Hits          634      635       +1     
- Misses        231      233       +2     
Flag Coverage Δ
unittests 73.15% <82.35%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogusa/calibrate.py 37.76% <100.00%> (+0.43%) ⬆️
ogusa/constants.py 100.00% <ø> (ø)
ogusa/get_micro_data.py 94.02% <81.25%> (-2.80%) ⬇️

@jdebacker jdebacker marked this pull request as ready for review June 5, 2024 15:46
@rickecon
Copy link
Member

rickecon commented Jun 7, 2024

@jdebacker. There another place where you might want to update the version to 0.1.9.

  • in lines 80-81 of ./cs-config/cs_config/functions.py, it looks like the get_version() function is calling an old version of OG-USA (v. 0.1.2).

I went ahead and committed this change.

@jdebacker
Copy link
Member Author

@jdebacker. There another place where you might want to update the version to 0.1.9.
in lines 80-81 of ./cs-config/cs_config/functions.py, it looks like the get_version() function is calling an old version of OG-USA (v. 0.1.2).
I went ahead and committed this change.

Ok - I noticed that, but decided to ignore since (1) it should read the version from the ogusa package and not be hardcoded like that and (2) I'm now convinced these cs-config files should be removed from the repo (but that will be done in a future PR).

@rickecon
Copy link
Member

rickecon commented Jun 7, 2024

@jdebacker. This looks great and all tests have passed. Merging.

@rickecon rickecon merged commit e994433 into PSLmodels:master Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants