Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuttX review scheduling note (cpuload) performance #11693

Closed
dagar opened this issue Mar 21, 2019 · 3 comments
Closed

NuttX review scheduling note (cpuload) performance #11693

dagar opened this issue Mar 21, 2019 · 3 comments

Comments

@dagar
Copy link
Member

dagar commented Mar 21, 2019

From profiling on STM32F7 we see that our NuttX scheduling note functions and hrt_absolute_time (used by nearly everything in PX4 including cpuload) are quite hot. https://github.com/PX4/Firmware/blob/1d5309060a7b26366f8aa0973fc078593c04a47e/src/lib/systemlib/cpuload.c#L107

We should consider using ram functions (CONFIG_ARCH_RAMFUNCS) as well as simpler cpuload calculations that aren't a burden on every single scheduler operation.

@dagar
Copy link
Member Author

dagar commented Jun 24, 2019

@stale
Copy link

stale bot commented Sep 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@dagar
Copy link
Member Author

dagar commented Sep 30, 2019

I'll come back to this once profiling on hardware. Either with https://github.com/orbcode/orbuculum or a J-Trace.

@dagar dagar closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants