Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify offboard mode for rover #12115

Closed
SalimTerryLi opened this issue May 30, 2019 · 4 comments
Closed

Verify offboard mode for rover #12115

SalimTerryLi opened this issue May 30, 2019 · 4 comments
Labels
question Rover 🚙 Rovers and other UGV

Comments

@SalimTerryLi
Copy link
Contributor

For general questions please use PX4 Discuss or Slack.

Describe problem solved by the proposed feature
This TODO prevents the offboard mode working on a rover. The expected solution should not limit the offboard mode as multirotor-only.

Describe your preferred solution
I' m asking for adding att_sp.thrust_body[0] = set_attitude_target.thrust; below but I don' t know how it would affect other frame types.
This will fix that rover cannot get throttle value from attitude setpoints.

Describe possible alternatives
I don' t know if there is any other way to solve this.

@julianoes julianoes added Rover 🚙 Rovers and other UGV question labels May 30, 2019
@julianoes
Copy link
Contributor

@SalimTerryLi thanks for raising this! Have you already tried to make this work by changing it? If so you could make a pull request that we could discuss.

@julianoes julianoes changed the title Ask for a further improvement of a TO-DO about offboard mode Verify offboard mode for rover May 30, 2019
@julianoes
Copy link
Contributor

FYI @ItsTimmy

@Jaeyoung-Lim
Copy link
Member

It would be awesome if this fix leads to enabling offboard mode in fixed wing too

@SalimTerryLi
Copy link
Contributor Author

#12149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Rover 🚙 Rovers and other UGV
Projects
None yet
Development

No branches or pull requests

3 participants