Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander mode initialization #12688

Closed
MaEtUgR opened this issue Aug 13, 2019 · 5 comments
Closed

Commander mode initialization #12688

MaEtUgR opened this issue Aug 13, 2019 · 5 comments

Comments

@MaEtUgR
Copy link
Member

MaEtUgR commented Aug 13, 2019

Describe problem solved by the proposed feature
I think one crucial point of the commander rewrite (#7055) is that the state machine doesn't just initialize in manual mode and the user can by accident arm in manual mode even if the vehicle/end-product doesn't officially support that mode. This is a huge problem and even less experienced hobby users or developers struggle with this logic and do mistakes.

Describe your preferred solution
As quickly discussed with @julianoes a class handling the intention of the user regarding the mode in terms of configuration, different inputs, switching would be useful. The output of that would then just be what the user wants decoupled from any feasibility, failsafe, execution. The state machine should then start in an initialization state that cannot by accident be used to start the vehicle and from there the class representing the user intention can start switching into the appropriate mode. Depending on the use case the defaults can then be configured such that a production vehicle might never default to manual mode or even support it as the user intention.

Medium-term I'd like to try to come up with a useful proposal such that we can do some progress and iterate without rewriting everything at once. The goal is to relieve the main commander module from some functionality while improving the user experience and improve test coverage. Hopefully I'll find the time for that.

@stale
Copy link

stale bot commented Nov 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Nov 11, 2019
@MaEtUgR MaEtUgR removed the stale label Feb 19, 2020
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Feb 19, 2020

This is a reoccuring problem and we keep on coming up with workarounds, I think it's worth a more clean solution. I hope I get to it soon.

@stale
Copy link

stale bot commented May 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label May 19, 2020
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Mar 10, 2021

Related: #16614

@stale stale bot removed the stale label Mar 10, 2021
@bkueng
Copy link
Member

bkueng commented Oct 25, 2022

Done in #20172

@bkueng bkueng closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants