Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Digest (11 August, 2019 - 18 August, 2019) #12733

Closed
weekly-digest bot opened this issue Aug 18, 2019 · 0 comments
Closed

Weekly Digest (11 August, 2019 - 18 August, 2019) #12733

weekly-digest bot opened this issue Aug 18, 2019 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Aug 18, 2019

Here's the Weekly Digest for PX4/Firmware:


ISSUES

Last week 50 issues were created.
Of these, 17 issues have been closed and 33 issues are still open.

OPEN ISSUES

💚 #12731 [DO NOT MERGE]: NuttX lazy fpu, by dagar
💚 #12730 [WIP]: handle gyro filter (IMU_GYRO_CUTOFF) in vehicle_angular_velocity, by dagar
💚 #12728 pmw3901 cleanup and register updates from PixArt, by dagar
💚 #12726 Flarm linux, by Lafon2
💚 #12725 Compile Firmware Errors "about cmake and build/", by qinglixinlei
💚 #12722 v5x sensors bmi, by davids5
💚 #12720 [drivers & uORB] Differentiate distance sensors by ID's (not only by the rotation), by TSC21
💚 #12719 FlightTaskAutoLine: speed_sp_prev_track calculation, by roangel
💚 #12718 PX4 NuttX SPI class always use SPI_LOCK(), by dagar
💚 #12716 Throttle goes up to 100 % and over FW_THR_MAX, by moreba1
💚 #12715 commander: add force arm CLI option (commander arm -f), by bkueng
💚 #12714 Clarify TRIG_PINS on FMU, by hamishwillee
💚 #12713 Add parameter CBRK_PREARM_LCK to lock actuators when prearmed, by jlecoeur
💚 #12712 Create mugin_vtol.main.mix, by BanthaRage
💚 #12710 Prevent GPS injection from choking the GPS driver, by potaito
💚 #12709 Commander: offboard failsafe cleanup, by jlecoeur
💚 #12707 Create mugin_vtol.aux.mix, by BanthaRage
💚 #12706 Create 13030_mugin_vtol, by BanthaRage
💚 #12705 [WIP]: DF IMU drivers (mpu9250, mpu6050, lsm9ds1) move to PX4Accelerometer/PX4Gyroscope/PX4Magnetometer, by dagar
💚 #12704 [WIP]: Infineon DPS310 Barometer, by dagar
💚 #12703 [WIP]: Bosch BMI088 IMU driver using FIFOs and DRDY interrupts, by dagar
💚 #12701 [WIP]: NuttX preparation for SPI DMA, by dagar
💚 #12700 [WIP]: create hovergames airframe, by dagar
💚 #12699 camera trigger parameters not appear, by moreba1
💚 #12696 Pr rally points, by sfuhrer
💚 #12695 [WIP] Refactor the ll40ls namespace driver methods to more closely match other distance sensor driver implementations, by mcsauder
💚 #12692 Pixhawk Cube_calibration issue on Master, by Tony3dr
💚 #12690 Distance senslr ll40ls will never be executed without running IMU driver, by hyonlim
💚 #12689 [MC / VTOL] Take off ramp overshoots MPC_TKO_SPEED constraint, by ThomasRigi
💚 #12688 Commander mode initialization, by MaEtUgR
💚 #12687 Commander: small user experience fixes found during demo testing, by MaEtUgR
💚 #12684 VTOL: keep status (MC/FW) when switching out of mission mode, by sfuhrer
💚 #12683 [BACKPORT] logger: fix rare case where logging stops, by bkueng

CLOSED ISSUES

❤️ #12732 vscode recommended extensions update docker and ros, by dagar
❤️ #12729 Jenkins hardware print more output, run logger, stop modules, by dagar
❤️ #12727 Jenkins hardware target general px4_fmu-v5, by dagar
❤️ #12724 add px4_fmu-v5_critmonitor build, by dagar
❤️ #12723 add px4_fmu-v5_irqmonitor build, by dagar
❤️ #12721 fix typo that was causing build to fail rpi., by fghanei
❤️ #12717 Update submodule mavlink v2.0 to latest Fri Aug 16 12:37:56 UTC 2019, by dagar
❤️ #12711 更新, by spurmoon
❤️ #12708 Orbit failsafe: Prevent crashes because of zero thrust , by Stifael
❤️ #12702 Rename _accel_horz_lp -> _xy_accel_filtered, delete unneeded #includes in FixedwingLandDetector, by mcsauder
❤️ #12698 commander: fix arming auth param translation, by julianoes
❤️ #12697 px_mkfw: add git commit hash to .px4 file, by bkueng
❤️ #12694 [WIP] bmp388 - cleanup, removal of ioctl, by modaltb
❤️ #12693 [WIP] bmp388 cleanup, removal of ioctl, by modaltb
❤️ #12691 stream OBSTACLE_DISTANCE to GCS, by mrivi
❤️ #12686 mRo Control Zero F7 board support, by dagar
❤️ #12685 Arm authorization fails on first attempt, succeeds erroneously after, by mattagiii

LIKED ISSUE

👍 #12708 Orbit failsafe: Prevent crashes because of zero thrust , by Stifael
It received 👍 x2, 😄 x0, 🎉 x1 and ❤️ x1.

NOISY ISSUE

🔈 #12685 Arm authorization fails on first attempt, succeeds erroneously after, by mattagiii
It received 9 comments.


PULL REQUESTS

Last week, 74 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 4 pull requests were opened.
💚 #12731 [DO NOT MERGE]: NuttX lazy fpu, by dagar
💚 #12726 Flarm linux, by Lafon2
💚 #12722 v5x sensors bmi, by davids5
💚 #12701 [WIP]: NuttX preparation for SPI DMA, by dagar

UPDATED PULL REQUEST

Last week, 49 pull requests were updated.
💛 #12730 [WIP]: handle gyro filter (IMU_GYRO_CUTOFF) in vehicle_angular_velocity, by dagar
💛 #12728 pmw3901 cleanup and register updates from PixArt, by dagar
💛 #12719 FlightTaskAutoLine: speed_sp_prev_track calculation, by roangel
💛 #12718 PX4 NuttX SPI class always use SPI_LOCK(), by dagar
💛 #12715 commander: add force arm CLI option (commander arm -f), by bkueng
💛 #12714 Clarify TRIG_PINS on FMU, by hamishwillee
💛 #12713 Add parameter CBRK_PREARM_LCK to lock actuators when prearmed, by jlecoeur
💛 #12712 Create mugin_vtol.main.mix, by BanthaRage
💛 #12710 Prevent GPS injection from choking the GPS driver, by potaito
💛 #12709 Commander: offboard failsafe cleanup, by jlecoeur
💛 #12707 Create mugin_vtol.aux.mix, by BanthaRage
💛 #12706 Create 13030_mugin_vtol, by BanthaRage
💛 #12705 [WIP]: DF IMU drivers (mpu9250, mpu6050, lsm9ds1) move to PX4Accelerometer/PX4Gyroscope/PX4Magnetometer, by dagar
💛 #12704 [WIP]: Infineon DPS310 Barometer, by dagar
💛 #12703 [WIP]: Bosch BMI088 IMU driver using FIFOs and DRDY interrupts, by dagar
💛 #12700 [WIP]: create hovergames airframe, by dagar
💛 #12696 Pr rally points, by sfuhrer
💛 #12695 [WIP] Refactor the ll40ls namespace driver methods to more closely match other distance sensor driver implementations, by mcsauder
💛 #12687 Commander: small user experience fixes found during demo testing, by MaEtUgR
💛 #12684 VTOL: keep status (MC/FW) when switching out of mission mode, by sfuhrer
💛 #12683 [BACKPORT] logger: fix rare case where logging stops, by bkueng
💛 #12681 Add max_altitude and _vehicle_attitude.timestamp validity checks to MulticopterLandDetector and standardize var naming, by mcsauder
💛 #12673 Integrate INA226 with PX4, by ItsTimmy
💛 #12672 Don't override MAVLink behavior in SITL .rc file, by pgorczak
💛 #12665 Add GPS_GLOBAL_ORIGIN mavlink msg., by nsteele
💛 #12664 Orbit approach with a line trajectory library, by MaEtUgR
💛 #12658 Update vehicle_local_position.ref_alt comment to reflect how ref_alt …, by nsteele
💛 #12650 create mc_rate_control (split out of mc_att_control), by dagar
💛 #12634 [WIP] Dev dshot, by Igor-Misic
💛 #12619 Rename VT_PSHER_RMP_DT to VT_PUSHER_RMP_DT to close PR #11680, by mcsauder
💛 #12601 [WIP]: temperature_compensation module, by dagar
💛 #12593 [WIP Do NOT MERGE] v5x sensors, by davids5
💛 #12575 [WIP]: ST VL53L1X ToF driver, by dagar
💛 #12551 Add calibration parameters for multiple batteries, by ItsTimmy
💛 #12532 Enable offboard position setpoints for Fixedwing position control, by Jaeyoung-Lim
💛 #12507 Accomplish requisite work to close out PR #11431., by mcsauder
💛 #12506 Add generic vtol tailsitter airframe and modifiy 4001_quad_x and 13001_caipirinha_vtol to simplify PR 9849, by mcsauder
💛 #12494 Switch into last mode after landing and disarming after RTL/Land, by ItsTimmy
💛 #12480 When setting pos_sp_triplet yaw, also set the yaw valid flag to true, by dusan19
💛 #12479 PID autotuner for velocity loop, by bresch
💛 #12464 WIP: Use loiter to alt & vtol land for RTL, by RomanBapst
💛 #12436 NuttX enable SPI DMA per board, by dagar
💛 #12227 ekf2 move to WQ with uORB callback scheduling, by dagar
💛 #12224 px4fmu move to WQ with uORB callback scheduling, by dagar
💛 #12175 AttitudeControl: let the user set yaw weight directly via parameter, by MaEtUgR
💛 #12148 Thoneflow 3901U Driver, by mhkabir
💛 #11874 Cherry pick the src/modules/land_detector/ directory and voted_sensors_update.h from PR #9756, by mcsauder
💛 #11665 Jenkins: add iris optical flow SITL test, by lamping7
💛 #11067 Feature: go-around patterns for missions, by almaaro

MERGED PULL REQUEST

Last week, 21 pull requests were merged.
💜 #12729 Jenkins hardware print more output, run logger, stop modules, by dagar
💜 #12727 Jenkins hardware target general px4_fmu-v5, by dagar
💜 #12724 add px4_fmu-v5_critmonitor build, by dagar
💜 #12723 add px4_fmu-v5_irqmonitor build, by dagar
💜 #12721 fix typo that was causing build to fail rpi., by fghanei
💜 #12717 Update submodule mavlink v2.0 to latest Fri Aug 16 12:37:56 UTC 2019, by dagar
💜 #12708 Orbit failsafe: Prevent crashes because of zero thrust , by Stifael
💜 #12702 Rename _accel_horz_lp -> _xy_accel_filtered, delete unneeded #includes in FixedwingLandDetector, by mcsauder
💜 #12698 commander: fix arming auth param translation, by julianoes
💜 #12697 px_mkfw: add git commit hash to .px4 file, by bkueng
💜 #12694 [WIP] bmp388 - cleanup, removal of ioctl, by modaltb
💜 #12691 stream OBSTACLE_DISTANCE to GCS, by mrivi
💜 #12686 mRo Control Zero F7 board support, by dagar
💜 #12679 logger: fix rare case where logging stops, by bkueng
💜 #12638 stm32 and kinetis adc driver move from ISR (hrt_call_every) to new WQ, by dagar
💜 #12608 splitting preflight and land disarm times into 2 parameters, by catch-twenty-two
💜 #12559 Mavlink: Fix forwarding of messages with target system/component id, by maowen
💜 #12477 uavcan flow support (Here Flow), by DanielePettenuzzo
💜 #12379 Implement ModuleParams inheritance in the VtolLandDetector class., by mcsauder
💜 #12145 introduce sensor_gyro_control message (1 kHz rate controller), by dagar
💜 #11249 motor_ramp: set fmu in test mode and main cleanup, by DanielePettenuzzo


COMMITS

Last week there were 29 commits.
🛠️ Jenkins hardware run logger and attempt to stop modules by dagar
🛠️ Jenkins hardware print AUX pwm info by dagar
🛠️ Jenkins hardware select airframe 4001 on fmu-v4 by dagar
🛠️ Jenkins hardware default airframe 4001 -> 13000 (run all controllers) by dagar
🛠️ Jenkins hardware target general px4_fmu-v5 by dagar
🛠️ px4_fmu-v5: add critical section monitor build (#12724) by dagar
🛠️ Jenkins hardware run adc test by dagar
🛠️ kinetis/adc move to new WQ by dagar
🛠️ stm32/adc move to new WQ by dagar
🛠️ px4_fmu-v5: add irqmonitor build (#12723) by dagar
🛠️ rpi_rc_in: fix typo that was causing build to fail rpi by fghanei
🛠️ [Update submodule mavlink v2.0 to latest Fri Aug 16 12:37:56 UTC 2019 (#12717) - mavlink v2.0 in PX4/Firmware (be3d09c): https://github.com/mavlink/c_library_v2/commit/0385f82286df78d51b06e5e325b13e2411ba2170
- mavlink v2.0 current upstream: https://github.com/mavlink/c_library_v2/commit/dc26ccd71dcb0138b23176233eade1c04a09b462
- Changes: https://github.com/mavlink/c_library_v2/compare/0385f82286df78d51b06e5e325b13e2411ba2170...dc26ccd71dcb0138b23176233eade1c04a09b462

 dc26ccd 2019-08-15 PX4BuildBot - autogenerated headers for rev https://github.com/mavlink/mavlink/tree/e5597b68bd5a98bf689aa056c623da480e7ef17a](https://github.com/PX4/Firmware/commit/48f5ab2896ce1eff20401ab887cc0a8e792288bf) by [dagar](https://github.com/dagar)

🛠️ introduce sensor_gyro_control message for vehicle_angular_velocity (#12145) by dagar
🛠️ [uavcan: add optical flow support (Here Flow) * move uavcan dsdlc generation to module

Signed-off-by: DanielePettenuzzo [email protected]](be3d09c) by DanielePettenuzzo
🛠️ Fix typo by bresch
🛠️ Orbit failsafe: switch internal_state to Posctrl such that Manual-Positionctrl is activated after failsafe recovery. This is needed because Orbit can only be invoked via vehicle_command msg. by Stifael
🛠️ motor_ramp: set fmu in test mode and cleanup (#11249) and restore pwm min after test by DanielePettenuzzo
🛠️ Rename _accel_horz_lp -> _xy_accel_filtered to standardize naming, use time literal, and delete unneeded #includes in the FixedwingLandDetector class. by mcsauder
🛠️ mavlink_main: stream OBSTACLE_DISTANCE to GCS by mrivi
🛠️ mavlink: match commands aimed at any sysid/compid When we send a command to any sysid or any compid, we need to match an ack from a specific sysid or compid. If we don't do that, we keep sending retransmissions and eventually time out. by julianoes
🛠️ commander: fix arming auth param translation The int32 param COM_ARM_AUTH is mapped to a packed struct. However, this struct was not actually packed (anymore) and therefore the values were applied incorrectly. I fixed this by applying the packed attribute. By using a union with a int32_t I could rid of the warning about address-of-packed-member. by julianoes
🛠️ mRo Control Zero F7 initial board support by dagar
🛠️ px_mkfw: add git commit hash to .px4 file by bkueng
🛠️ Implement ModuleParams inheritance in the VtolLandDetector class. Requires PR #12356. by mcsauder
🛠️ Update commander_params.c Addressing parameter description syntax by catch-twenty-two
🛠️ updating pre-takeoff and landding values to defaults by catch-twenty-two
🛠️ splitting preflight and land disarm times into 2 parameters by catch-twenty-two
🛠️ [Mavlink: Fix forwarding of messages with target system/component id (#12559) Mavlink does not correctly forward messages that have the target_system or target_component routing fields in the message.

Some investigation revealed that the Mavlink::forward_message function is incorrectly utilizing the mavlink_msg_entry_t.target_system_ofs and mavlink_msg_entry_t.target_component_ofs fields. These offsets are intended to be used relative to the start of the message payload. But, as implemented, these offsets are incorrectly being used relative to the start of the message. This pull-request corrects that problem.

I also correctly made use of the mavlink_msg_entry_t.flags field to determine if a message contains a target_system or target component field. The previous check incorrectly assumed that they would always be non-zero if present.

Signed-off-by: Mark Owen [email protected]](e25db01) by maowen
🛠️ logger: unconditionally call _writer.notify() The file writer thread could get into a state where it blocked infinitely on pthread_cond_wait() (or rather until the logging stops). This is very rare and the following conditions must be met: - the buffer is almost empty (<4KB filled), so that the writer thread does not write anything. - an fsync call is scheduled (happens once every second) - the fsync call takes a long time (several 100ms), during which time the complete log buffer fills up. The main thread would then get into dropout state where it does not call _writer.notify() anymore. Notifying the writer thread on every loop update of the main thread fixes that. It does not increase resource usage. by bkueng


CONTRIBUTORS

Last week there were 11 contributors.
👤 dagar
👤 fghanei
👤 DanielePettenuzzo
👤 bresch
👤 Stifael
👤 mcsauder
👤 mrivi
👤 julianoes
👤 bkueng
👤 catch-twenty-two
👤 maowen


STARGAZERS

Last week there were 21 stagazers.
danielhe
netesheng
zhanne88
BillYJT
hacklock
chenchuhan
sona-19
habedi
Jian-Yin-Shine
vas59
D3473R
scoos
BanthaRage
ZeroX-86
Luog1994
nocord
ViatorSun
jdzlxm
NineLivesCat
martinliangtz
dsaffo
You all are the stars! 🌟


RELEASES

Last week there were no releases.


That's all for last week, please 👀 Watch and Star the repository PX4/Firmware to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant