Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multicopter velocity control gains backwards compatibility depends on hover thrust #14720

Closed
MaEtUgR opened this issue Apr 21, 2020 · 0 comments · Fixed by #14749
Closed

Multicopter velocity control gains backwards compatibility depends on hover thrust #14720

MaEtUgR opened this issue Apr 21, 2020 · 0 comments · Fixed by #14749

Comments

@MaEtUgR
Copy link
Member

MaEtUgR commented Apr 21, 2020

Describe the bug
The rescaling of the velocity controller with the backwards compatibility term depending on the hover thrust combined with the hover thrust estimator adjusting the hover thrust: https://github.com/PX4/Firmware/blob/master/src/modules/mc_pos_control/PositionControl/PositionControl.cpp#L151

I still think it's at least part of what we've seen in #14640

The goal was the exact opposite to get less dependency and more reproducible tuning but trying to remain backwards compatible it depends now even more on the hover thrust.

Expected behavior
The scale should be adjusted by a constant hover thrust independent factor for compatibility and then the parameter replaced with a rescaled version applying the constant factor for automatic conversion.

Additional context
#14212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants