ROMFS split rc.board into defaults, sensors, and extras #11044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
changed the title
bkueng
reviewed
Jan 7, 2019
davids5
previously requested changes
Jan 7, 2019
|
Rebased on master and resolved conflicts. Need to do another pass to address all comments. |
dagar
changed the title
dagar
force-pushed
the
pr-init_fixes
branch
2 times, most recently
from
0042061 to
25c8beb
Compare
|
The default value for SYS_FMU_TASK is already 1, so updated the scripting to only set this to 0 for fmu-v2, v3 and auav-x21. |
|
Good to go? If no one has a major objection I'd prefer to get this in immediately and follow up in additional issues/PRs. This is getting difficult to rebase. |
|
@dagar good from my pov |
bkueng
reviewed
Jan 15, 2019
bkueng
approved these changes
Jan 16, 2019
6 tasks
|
PX4 user guide issue to follow up on serial port docs. PX4/PX4-user_guide#417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve a number of issues and enable further customization I've split the optional per board provided
rc.boardinit script intorc.board_defaults,rc.board_sensors, andrc.board_extras.rc.board_defaults
rc.board_sensors
rc.board_extras
I'm sure there are other little problems in startup, let's take this as an opportunity to carefully review everything and identify other problems.