Add unit tests #12069
Closed
Add unit tests #12069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visibility.h is included globally in PX4 via cmake compile flags. It contains poisoning the exit() command which is used by gtest to close the test application. Removing the flag for gtest compilation fixes the compile error: gtest.cc:4757:7: error: attempt to use poisoned "exit"
Example: Before when you passed "make tests TESTFILTER=Attitude" and subsequently "make tests TESTFILTER=Atti" it found the string "TESTFILTER=Atti" in "TESTFILTER=Attitude" and hence the check if the configuration is already correct passed. The fix checks for the configuration parameter including the subsequent space separator and after that strips the space away again such that the list VERIFIED_CMAKE_OPTIONS doesn't contain trailing spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.
Describe problem solved by the proposed pull request
A clear and concise description of the problem this proposed change will solve. E.g. For this use case I ran into...
Test data / coverage
How was it tested? What cases were covered? Logs uploaded to https://review.px4.io/ and screenshots of the important plot parts.
Describe your preferred solution
A clear and concise description of what you have implemented.
Describe possible alternatives
A clear and concise description of alternative solutions or features you've considered.
Additional context
Add any other related context or media.