WIP: commander re-evaluate RC mode switch when local position becomes valid #12110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One idea would be to limit it to when disarmed or landed. |
dagar
force-pushed
the
pr-commander_reevaluate_lpos
branch
from
12732cc to
a16daa6
Compare
|
@MaEtUgR thoughts on this one? |
julianoes
approved these changes
Jul 31, 2019
mhkabir
approved these changes
Jul 31, 2019
|
@dagar still draft or good to go? |
|
This came up during the October 9, 2019 dev call. @MaEtUgR can you please drive this forward? |
MaEtUgR
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MaEtUgR I wanted to extend the RC mode switch re-evaluation logic for a multicopter with optical flow to enter position control mode as soon as possible on bootup.
Now that I look at this logic again I'm wondering if it should be limited to prevent forcing the re-evaluation in a failsafe scenario after position validity is regained.