-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] uORB Subscription callback testing #12256
Conversation
@dagar, I gave it a quick flight test and it was lively! :) https://review.px4.io/plot_app?log=adf7ed32-d3af-4559-bc49-3089d287e9e5 This definitely has an impact on timing, I might need to play with tuning gains. The big thing that needs digging into was that the motors were occasionally twitching/spinning while landed and disarmed. I performed a few more short flights in manual mode only and position mode only with similar results. Here is a manual flight: https://review.px4.io/plot_app?log=f6f65fd3-3a24-4d58-a5e5-aa05d2061ce9 |
Thanks Mark, do you have a good log from this vehicle close to master? The problem is likely in the px4fmu driver (mixing and pwm output on the pixhawk 4 mini). #12224 |
Hi @dagar, here is a flight from current master on the same airframe for an a/b comparison, |
4eb0346
to
024503c
Compare
Tested on Pixhawk 2 Cube V3:Flight Card 1 Modes Tested: Procedure: Notes: Flight Card 2 Modes Tested Procedure Note: Flight Card 3 Modes Tested Procedure Note: Logs: Flight card 1: https://review.px4.io/plot_app?log=889ff9ad-23e9-457a-97f8-aa9ed177e82e Flight card 2: https://review.px4.io/plot_app?log=0ac6a07c-9a03-4bad-bb04-7e6dce2ed9e4 Flight card 3 : https://review.px4.io/plot_app?log=0969d351-92c8-414f-a6f9-2c1638a40360 Flight card 3: https://review.px4.io/plot_app?log=0919a0f4-f2a1-4209-abdc-5e69fdba276c Tested on Pixhawk 2 Cube V3:Modes Tested Position Mode: Good. - Procedure Notes: Logs: Comparison to master Tested on PixRacer V4:Modes Tested Position Mode: Good. - Procedure Notes: Logs: Comparison to master Tested on PixRacer V4:Flight Card 3 Modes Tested Procedure Note: Logs |
Here is an additional flight log on pixhawk 4 mini 250 racer: https://review.px4.io/plot_app?log=08a780ff-9c15-4064-9bb2-27617521d1f7 The current commit fixes the issue I mentioned above. The flight in this log was great. |
Tested on Pixhawk4 V5 f450 Position Mode: no issue logs: fc#2: https://review.px4.io/plot_app?log=de67c939-f6c3-4f02-866f-263f85176f7e fc#3: https://review.px4.io/plot_app?log=01e7590f-be7b-4db0-a844-262270dbfa80 fc#4: https://review.px4.io/plot_app?log=45cd2709-cd60-43b1-bf01-c95d96336ee5 master log: https://review.px4.io/plot_app?log=906cf7b4-0c3e-4abd-bd5f-bb3f110ce53e |
Thanks everyone! |
For testing #12207