Implement ModuleParams inheritance in the VtolLandDetector class. #12379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
vtol_land_detector_module_params
branch
from
39502a8 to
35fa8f9
Compare
mcsauder
force-pushed
the
vtol_land_detector_module_params
branch
from
35fa8f9 to
c6ffad4
Compare
mcsauder
force-pushed
the
vtol_land_detector_module_params
branch
from
c6ffad4 to
4286474
Compare
mcsauder
force-pushed
the
vtol_land_detector_module_params
branch
2 times, most recently
from
100eae6 to
0ff8956
Compare
mcsauder
force-pushed
the
vtol_land_detector_module_params
branch
from
0ff8956 to
ed1fe84
Compare
mcsauder
changed the title
mcsauder
force-pushed
the
vtol_land_detector_module_params
branch
from
ed1fe84 to
6356543
Compare
mcsauder
force-pushed
the
vtol_land_detector_module_params
branch
from
6356543 to
20b7c51
Compare
dagar
approved these changes
Aug 14, 2019
julianoes
approved these changes
Aug 14, 2019
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR implements
ModuleParamsinheritance in theVtolLandDetectorclass following PR #12356.Test data / coverage
NOTE: I do not have hardware to flight test this PR.
Additional context
See PR #12356, #12209 and #9756. This PR requires #12356 prior to acceptance.
@dagar and @bkueng , please let me know if you have any questions on this PR. Thanks!
-Mark