[WIP] bmp388 - cleanup, removal of ioctl #12694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davids5 as discussed, small update in case it helps your efforts! |
|
@modaltb - thank you! |
davids5
pushed a commit
that referenced
this pull request
Aug 16, 2019
* [WIP] bmp388 cleanup, removal of ioctl * [WIP] bmp388 - fix issue with build error with SPI
davids5
pushed a commit
that referenced
this pull request
Aug 17, 2019
* [WIP] bmp388 cleanup, removal of ioctl * [WIP] bmp388 - fix issue with build error with SPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
Further work on support for bmp388 barometer. This PR consists of some cleanup, the CLI portion of the driver is pulled to bmp388_main.cpp, the ioctl usage is totally removed, and some other small updates. It should now run as expected when launched at startup and publish data.
Test data / coverage
This has been in test on our "FMU v5m" board (which is variant of the v5x). It's on an I2C bus, and pressure/temperature data has been reliably been publishing. The driver looks stable to me, but more real world testing is obviously needed.
Data has been confirmed via nsh and in QGC's analyze feature.
NOTE: ONLY THE I2C INTERFACE HAS BEEN TESTED.
Describe your preferred solution
N/A
Describe possible alternatives
N/A
Additional context
Add any other related context or media.