Clarify TRIG_PINS on FMU #12714
Merged
Clarify TRIG_PINS on FMU #12714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
Aug 16, 2019
bkueng
previously approved these changes
Aug 16, 2019
|
Can you look into the CI issue? http://ci.px4.io:8080/blue/organizations/jenkins/PX4%2FFirmware/detail/PR-12714/2/pipeline/ |
|
Ran astyle. Should fix this. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TRIG_PINS docs refer to AUX, but this driver uses direct pin access to FMU. So on a pixhawk board that has no I/O board it will actually map to MAIN.
This follows on from PX4/PX4-Devguide#852 (comment)