Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new InvenSense icm20948 driver on SPI with AK09916 mag #14567

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

dagar
Copy link
Member

@dagar dagar commented Apr 1, 2020

No description provided.

@mrpollo
Copy link
Contributor

mrpollo commented Apr 6, 2020

@dagar Is this PR blocked by other future changes?

@dagar dagar force-pushed the pr-icm20948_spi branch from f2e50ef to adc40ba Compare April 22, 2020 01:43
@dagar dagar force-pushed the pr-icm20948_spi branch from adc40ba to 9793d4a Compare May 21, 2020 13:54
@dagar dagar requested a review from dakejahl May 21, 2020 13:54
@dagar dagar marked this pull request as ready for review May 21, 2020 13:54
@dagar dagar added this to the Release v1.11.0 milestone May 21, 2020
@dagar dagar self-assigned this May 21, 2020
@dakejahl
Copy link
Contributor

image

This is good to merge.

dakejahl
dakejahl previously approved these changes May 22, 2020
@dagar dagar force-pushed the pr-icm20948_spi branch from 9ae1b8e to d3e7318 Compare May 22, 2020 03:50
@dagar dagar changed the title [WIP] new InvenSense icm20948 driver on SPI with AK09916 mag new InvenSense icm20948 driver on SPI with AK09916 mag May 22, 2020
@dagar
Copy link
Member Author

dagar commented May 22, 2020

Thanks @dakejahl

@@ -79,6 +79,7 @@
#define DRV_IMU_DEVTYPE_ICM20649 0x25
#define DRV_IMU_DEVTYPE_ICM42688P 0x26
#define DRV_IMU_DEVTYPE_ICM40609D 0x27
#define DRV_IMU_DEVTYPE_ICM20948 0x28
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, I wouldn't typically do this, but the IMU portion of the old icm20948 never worked properly in the first place.

@dagar dagar merged commit 951969b into master May 22, 2020
@dagar dagar deleted the pr-icm20948_spi branch May 22, 2020 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants