[WIP] Add Optical Flow Driver for Upflow LC302 module #14723
Conversation
|
Great. When this is integrated can you update the record in http://docs.px4.io/master/en/sensor/pmw3901.html ? |
|
@hamishwillee Glad to do, but this one is not using PMW3901, and have its own protocol, is that a good idea? Should I create a new page? Or create 3901-like section is good to go? |
|
Just read the page again, I think create a new page is better. |
| dev->_fd_open(); | ||
| } | ||
|
|
||
| work_queue(HPWORK, &(dev->_work), (worker_t)&upflow_lc302::cycle_trampoline, |
There was a problem hiding this comment.
Needs to be updated to use the new WorkQueue.
There was a problem hiding this comment.
Yes, but I'm not familiar on this part, I need your help.
| @@ -34,3 +34,4 @@ | |||
| add_subdirectory(paw3902) | |||
| add_subdirectory(pmw3901) | |||
| add_subdirectory(px4flow) | |||
| add_subdirectory(upflow) | |||
There was a problem hiding this comment.
Should we name this more descriptively like upflow_lc302?
There was a problem hiding this comment.
I pretty sure if they have new module, they would continue use this protocol. If need to change, just minor adjustment. Then one driver is enough for this company, no more driver will coming next.
dagar
added
Drivers 🔧
|
@bys1123 are you setup to flight test this? If so I can take a pass to clean it up. |
Co-Authored-By: Daniel Agar <[email protected]>
|
@dagar I'm ready to test this, and the manufacture also will do the test too, I need your help to make this driver up-to-date, thank you. |
|
@bys1123 Yes please - create a new page for a new implementation that is unrelated to the others. I'll help with subedit. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Upflow LC302 has a very nice performance like PMW3901. Worth to upstream.
Product User Manual(LC-302-3C)V1.1.pdf
This commit is an old one, need some work to make it compatible with current master.
This PR will fix #13631 .