sched/wdog: fix signature for wdentry_t #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc 8.2.1. doesn't allow lazy function pointer casting anymore. When building px4-firmware 'make omnibus_f4sd_default' it complains: wdog/wd_start.c:151:20: error: cast between incompatible function types from 'wdentry_t' Changing the signature for wdentry_t will break cdcacm_rxtimeout(). To fix this we use a va_list there.
|
Thanks @bruenn, we try to stay in sync with the upstream NuttX project. Could you contribute this to upstream NuttX (https://bitbucket.org/nuttx/nuttx/src/master/) and then we'll either backport the commit or pick it up the next time we upgrade. |
|
I send a bug report to upstream: |
7 tasks
|
I pushed a rebased version here: https://github.com/MaEtUgR/NuttX/tree/arm-gcc-9 |
7 tasks
|
FYI when testing to compile on ARM GCC 9.2 with the latest NuttX version in use on master (fdf1837) I don't see this problem popping up anymore. I'm assuming it was fixed in upstream NuttX and we merged it since. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 8.2.1. doesn't allow lazy function pointer casting anymore. When building
px4-firmware 'make omnibus_f4sd_default' it complains:
wdog/wd_start.c:151:20: error: cast between incompatible function types from 'wdentry_t'
Changing the signature for wdentry_t will break cdcacm_rxtimeout(). To fix
this we use a va_list there.
Related to PX4/PX4-Autopilot#12283