Skip to content

Commit

Permalink
px4iofirmware use std NAN instead of undefined 0.0f/0.0f
Browse files Browse the repository at this point in the history
 - closes #9277
  • Loading branch information
dagar committed Apr 12, 2018
1 parent 1ecfb22 commit 1022a08
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 19 deletions.
3 changes: 1 addition & 2 deletions src/modules/px4iofirmware/mixer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ extern "C" {
* Maximum interval in us before FMU signal is considered lost
*/
#define FMU_INPUT_DROP_LIMIT_US 500000
#define NAN_VALUE (0.0f/0.0f)

/* current servo arm/disarm state */
static volatile bool mixer_servos_armed = false;
Expand Down Expand Up @@ -479,7 +478,7 @@ mixer_callback(uintptr_t handle,
control_group == actuator_controls_s::GROUP_INDEX_ATTITUDE_ALTERNATE) &&
control_index == actuator_controls_s::INDEX_THROTTLE) {
/* mark the throttle as invalid */
control = NAN_VALUE;
control = NAN;
}
}

Expand Down
20 changes: 3 additions & 17 deletions src/systemcmds/tests/test_mixer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,22 +37,10 @@
* Mixer load test
*/

#include <px4_config.h>

#include <sys/types.h>

#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <fcntl.h>
#include <limits>
#include <dirent.h>
#include <errno.h>
#include <string.h>
#include <time.h>
#include <limits.h>
#include <math.h>

#include <systemlib/err.h>
#include <px4_config.h>
#include <lib/mixer/mixer.h>
#include <systemlib/pwm_limit/pwm_limit.h>
#include <drivers/drv_hrt.h>
Expand All @@ -75,8 +63,6 @@ const unsigned output_max = 8;
static float actuator_controls[output_max];
static bool should_prearm = false;

#define NAN_VALUE (0.0f/0.0f)

#ifdef __PX4_DARWIN
#define MIXER_DIFFERENCE_THRESHOLD 30
#else
Expand Down Expand Up @@ -604,7 +590,7 @@ mixer_callback(uintptr_t handle, uint8_t control_group, uint8_t control_index, f

if (should_prearm && control_group == actuator_controls_s::GROUP_INDEX_ATTITUDE &&
control_index == actuator_controls_s::INDEX_THROTTLE) {
control = NAN_VALUE;
control = std::numeric_limits<float>::quiet_NaN();
}

return 0;
Expand Down

0 comments on commit 1022a08

Please sign in to comment.