Skip to content

Commit

Permalink
boards/arm/stm32f0l0g0/: Fix issues noted by nxstyle.
Browse files Browse the repository at this point in the history
  • Loading branch information
dvolpato authored and gregory-nutt committed Dec 20, 2019
1 parent b9638de commit 54d6a07
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 19 deletions.
10 changes: 6 additions & 4 deletions boards/arm/stm32f0l0g0/nucleo-g070rb/src/stm32_bringup.c
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ static void stm32_i2ctool(void)
* CONFIG_BOARD_LATE_INITIALIZE=y :
* Called from board_late_initialize().
*
* CONFIG_BOARD_LATE_INITIALIZE=n && CONFIG_LIB_BOARDCTL=y && CONFIG_NSH_ARCHINIT:
* CONFIG_BOARD_LATE_INITIALIZE=n && CONFIG_LIB_BOARDCTL=y
* && CONFIG_NSH_ARCHINIT:
* Called from the NSH library
*
****************************************************************************/
Expand Down Expand Up @@ -184,7 +185,6 @@ int stm32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize GPIO Driver: %d\n", ret);
return ret;
}
#endif

Expand All @@ -206,15 +206,17 @@ int stm32_bringup(void)
ret = stm32_timer_driver_setup("/dev/timer0", 6);
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: stm32_timer_driver_setup failed. TIM6: %d\n", ret);
syslog(LOG_ERR, "ERROR: stm32_timer_driver_setup failed. TIM6: %d\n",
ret);
}
#endif

#if defined(CONFIG_STM32F0L0G0_TIM7)
ret = stm32_timer_driver_setup("/dev/timer1", 7);
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: stm32_timer_driver_setup failed. TIM7: %d\n", ret);
syslog(LOG_ERR, "ERROR: stm32_timer_driver_setup failed. TIM7: %d\n",
ret);
}

#endif
Expand Down
28 changes: 14 additions & 14 deletions boards/arm/stm32f0l0g0/nucleo-g070rb/src/stm32_buttons.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,20 @@ uint32_t board_buttons(void)
* Button support.
*
* Description:
* board_button_initialize() must be called to initialize button resources. After
* that, board_buttons() may be called to collect the current state of all
* buttons or board_button_irq() may be called to register button interrupt
* handlers.
* board_button_initialize() must be called to initialize button resources.
* After that, board_buttons() may be called to collect the current state of
* all buttons or board_button_irq() may be called to register button
* interrupt handlers.
*
* After board_button_initialize() has been called, board_buttons() may be called to
* collect the state of all buttons. board_buttons() returns an 32-bit bit set
* with each bit associated with a button. See the BUTTON_*_BIT
* definitions in board.h for the meaning of each bit.
* After board_button_initialize() has been called, board_buttons() may be
* called to collect the state of all buttons. board_buttons() returns an
* 32-bit bit set with each bit associated with a button. See the
* BUTTON_*_BIT definitions in board.h for the meaning of each bit.
*
* board_button_irq() may be called to register an interrupt handler that will
* be called when a button is depressed or released. The ID value is a
* button enumeration value that uniquely identifies a button resource. See the
* BUTTON_* definitions in board.h for the meaning of enumeration
* value.
* board_button_irq() may be called to register an interrupt handler that
* will be called when a button is depressed or released. The ID value is a
* button enumeration value that uniquely identifies a button resource. See
* the BUTTON_* definitions in board.h for the meaning of enumeration value.
*
****************************************************************************/

Expand All @@ -123,7 +122,8 @@ int board_button_irq(int id, xcpt_t irqhandler, FAR void *arg)

if (id == BUTTON_USER)
{
ret = stm32_gpiosetevent(GPIO_BTN_USER, true, true, true, irqhandler, arg);
ret = stm32_gpiosetevent(GPIO_BTN_USER, true, true, true, irqhandler,
arg);
}

return ret;
Expand Down
3 changes: 2 additions & 1 deletion boards/arm/stm32f0l0g0/nucleo-g070rb/src/stm32_timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
* Configure the timer driver.
*
* Input Parameters:
* devpath - The full path to the timer device. This should be of the form /dev/timer0
* devpath - The full path to the timer device. This should be of the form
* /dev/timer0
* timer - The timer's number.
*
* Returned Value:
Expand Down

0 comments on commit 54d6a07

Please sign in to comment.