Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental build issues for IO #11036

Closed
bkueng opened this issue Dec 14, 2018 · 3 comments · Fixed by #12805
Closed

Incremental build issues for IO #11036

bkueng opened this issue Dec 14, 2018 · 3 comments · Fixed by #12805
Assignees
Labels
bug Tools Sub-tools used within PX4 ecosystem (scripts, etc)

Comments

@bkueng
Copy link
Member

bkueng commented Dec 14, 2018

  • incremental build for the IO is broken, i.e. a change to the IO firmware code is not included in a subsequent build.
  • make/ninja clean in build/px4_fmu-v5_default does not clean the IO build. However a subsequent build rebuilds the IO.
@dagar dagar self-assigned this Dec 14, 2018
@dagar
Copy link
Member

dagar commented Dec 14, 2018

The way this works is the px4io driver initiates the px4_io-v2 build. Previously this was done by calling make directly from a cmake custom command. Recently I changed it to use cmake ExternalProject (https://cmake.org/cmake/help/latest/module/ExternalProject.html) to work around a number of cmake IDE related issues.

The dependencies were never quite right in the previous setup. I'll look for a way we can use the real underlying dependencies with ExternalProject so that final px4 binary isn't rebuilt constantly.

@stale
Copy link

stale bot commented Mar 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@bresch
Copy link
Member

bresch commented Mar 28, 2019

The issue is still there: every time I want to test a modification I did in px4iofirmware, I have to do a make clean before I rebuild to include the changes.

@PX4 PX4 deleted a comment from stale bot Jun 26, 2019
@dagar dagar added this to the Release v1.10.0 milestone Jun 26, 2019
@julianoes julianoes added the Tools Sub-tools used within PX4 ecosystem (scripts, etc) label Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Tools Sub-tools used within PX4 ecosystem (scripts, etc)
Projects
None yet
4 participants