Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reposition vs Mission Pause #12544

Open
Stifael opened this issue Jul 23, 2019 · 6 comments
Open

Reposition vs Mission Pause #12544

Stifael opened this issue Jul 23, 2019 · 6 comments

Comments

@Stifael
Copy link
Contributor

Stifael commented Jul 23, 2019

To my understanding for both GoTo and for Mission-Pause the mavlink-msg MAV_CMD_DO_REPOSITION(192) is used. However, there is already a dedicated msg for pausing/continuing a mission called MAV_CMD_DO_PAUSE_CONTINUE (193 ). To be able to distinguish between GoTo and Pause also within the ulog, it would be beneficial to use 193 for mission-pause instead of 192.

Given that such a change requires changes on both PX4 and QGC, I opened the same issue on QGC as well (mavlink/qgroundcontrol#7612).

@Stifael Stifael changed the title Reposition vs Mission Paus Reposition vs Mission Pause Jul 23, 2019
@julianoes
Copy link
Contributor

Notes from dev call:

  • @julianoes I would think that change makes sense 😄

@MaEtUgR
Copy link
Member

MaEtUgR commented Apr 2, 2020

This was recently brought up in slack again and there was the idea to use DO_REPOSITION with coordinates set to NAN to command a stop. Using the existing pause command would probably be even more desired.

This is a related issue for goto/reposition executing in its own mode: #14576

@stale stale bot removed the stale label Apr 2, 2020
@PX4 PX4 deleted a comment from stale bot Apr 2, 2020
@hamishwillee
Copy link
Contributor

@MaEtUgR @DonLakeFlyer et al

Using the existing pause message would be much more desired. Why don't we do this?

Regarding MAV_CMD_DO_REPOSITION hacks, I'm not opposed to this as well as long as the documentation for the message in common.xml gets updated and everyone adopts the same approach. Is this what is expected to happen?

@DonLakeFlyer
Copy link
Contributor

DonLakeFlyer commented Apr 3, 2020

Using the existing pause message would be much more desired. Why don't we do this?

Do you mean this: MAV_CMD_DO_PAUSE_CONTINUE. First I've seen that. Does it actually work?

@hamishwillee
Copy link
Contributor

Probably not not on PX4, or this issue would be closed. Looks like we do respond to it in PX4 v1.11: 509be82

But implementing this is the "right thing to do" from a mavlink perspective (ie this is the command that meets the intention)

@stale
Copy link

stale bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants