Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Parameters in 1.11 #15872

Closed
ryanjAA opened this issue Oct 3, 2020 · 1 comment · Fixed by #15875
Closed

Missing Parameters in 1.11 #15872

ryanjAA opened this issue Oct 3, 2020 · 1 comment · Fixed by #15875
Assignees
Labels

Comments

@ryanjAA
Copy link
Contributor

ryanjAA commented Oct 3, 2020

There are several parameters that are quasi missing in 1.11 stable.

I say quasi as they are in the firmware but do not always show up in QGC.

com_power_count is listed and present in 1.11 (https://github.com/PX4/Firmware/blob/71db0903a910d35a18f10d74c851446a6f66d61f/src/modules/commander/commander_params.c#L926) but not in https://dev.px4.io/v1.11/en/advanced/parameter_reference.html

Some occasions (after several hard, not soft reboots) the parameter shows but I can not recreate making it show up routinely or by a specific method yet.

A param set com_power_count X when the parameter is not showing up yields an error message that the parameter is not present on the vehicle.

My short term workaround is not realistic (I've aded the parameter as a specific vehicle parameter so when setting autoconfig to vehicle standards, it populates the necessary parameters but this still disappears after a soft reboot, is does however enable changing it prior).

Additionally, the com_arm_ekf_XXX parameters do not show up as well.

This is discussed here https://px4.slack.com/archives/C0W2KUFFT/p1601402558029700 but as com_power_count is causing problems for users, it is important that this parameter be exposed, aside from the fact that something is not working correctly.

This has been tried on multiple pixhawk 1 units and computers with the same result. Anecdotally, the presence of the parameters may be related to soft and hard rebooting of the system.

@dagar
Copy link
Member

dagar commented Oct 3, 2020

It's likely the timing of initial param sync with commander not checking these things immediately. Let me take a look.

@dagar dagar added the bug label Oct 3, 2020
@dagar dagar self-assigned this Oct 3, 2020
dagar added a commit that referenced this issue Oct 3, 2020
 - this ensures the relevant parameters are marked active immediately
before parameter sync
 - fixes #15872
dagar added a commit that referenced this issue Oct 3, 2020
 - this ensures the relevant parameters are marked active immediately
before parameter sync
 - fixes #15872
dagar added a commit that referenced this issue Oct 3, 2020
 - this ensures the relevant parameters are marked active immediately
before parameter sync
 - fixes #15872
dagar added a commit that referenced this issue Oct 3, 2020
 - this ensures the relevant parameters are marked active immediately
before parameter sync
 - fixes #15872
mvacanti pushed a commit to mvacanti/PX4-Autopilot that referenced this issue Nov 27, 2020
 - this ensures the relevant parameters are marked active immediately
before parameter sync
 - fixes PX4#15872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants