Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: confusing/wrong description of SDLOG_PROFILE parameter #16904

Closed
lukegluke opened this issue Feb 21, 2021 · 5 comments · Fixed by #16912
Closed

logger: confusing/wrong description of SDLOG_PROFILE parameter #16904

lukegluke opened this issue Feb 21, 2021 · 5 comments · Fixed by #16912

Comments

@lukegluke
Copy link
Contributor

Default value is 1, that is the "Default set" (only bit 0 is set) and this doesn't allow estimator replay!

* This integer bitmask controls the set and rates of logged topics.
* The default allows for general log analysis and estimator replay, while
* keeping the log file size reasonably small.

@dagar
Copy link
Member

dagar commented Feb 21, 2021

Do you mean checking "Estimator replay (EKF2)" doesn't work without also having "Default set" checked?

@lukegluke
Copy link
Contributor Author

I mean that looking at phrase "The default allows for general log analysis and estimator replay", without checking meaning of particular bits, one can decide that default value 1 will be enough for further estimator replay.

@dagar
Copy link
Member

dagar commented Feb 22, 2021

Oh I see what you mean. We used to have estimator replay checked by default as well.

@dagar
Copy link
Member

dagar commented Feb 22, 2021

#16912

@lukegluke
Copy link
Contributor Author

@dagar, by the way, docs are also not reflect current default:
https://docs.px4.io/master/en/debug/system_wide_replay.html#prerequisites

All identified topics need to be logged at full rate (see logging). For ekf2 this is already the case with the default set of logged topics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants