System is arming (or thinks it is arming) even with Critical warnings (specifically "MAG SENSORS INCONSISTENT")

[Antiheavy]

PX4 1.7.3, installed on a Pixracer, using QGC v3.3.0. The pixracer is sitting on my desk connected to QGC over USB. I have a valid GPS fix. I try to Arm and it seems to let me even with the following Critical warnings:

Is this right?

[Antiheavy]

however, once i fixed the compass rotation problem (that was giving the "MAG SENSORS INCONSISTENT" warning), then the system properly prevents arming:

[dagar]

Working on a fix here - https://github.com/PX4/Firmware/tree/pr-commander_preflight

[taileron]

I think it´s not so bad to allow arming for stabilized flights and reject only e.g. positopn, auto mission or rtl that is directly dependent on the sensor´s errors

[dagar]

@taileron I agree, but it needs to be done explicitly and I'm not entirely sure how we'd want to go about that.

Some of these requirements we could determine from the system configuration. For example if the user has and RC or data link loss failsafe configured for RTL then at arming time the system could require a valid global position estimate and valid home position.

[taileron]

@dagar some errors disappear when the fc runs a minute but mostly it is necessary to reboot the system to get rid of conditions that could prevent arming.
so what´s about to have the possibility or do it automatic at the attempt of arming: repeat the preflight check after 40 ... 120 sec when temperatures and reference voltages are more stable and more gps satellites than directly after boot, deleting all previous preflight errors + nsh "commander check" with current sensor values

[dagar]

Immediate fix in #9193.