Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmu:Add MODE_4PWM1CAP, MODE_5PWM, MODE_5PWM1CAP #10567

Merged
merged 2 commits into from
Sep 28, 2018

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Sep 25, 2018

This extends the Capture support for FMU
CHAN 5 and 6.

FYI @DanielePettenuzzo, @mhkabir this is needed for #10295 (comment)

I will do a PR against your pr with the IOCTL code in it. I tested this on a FMUv2 (2MB) on FMU_CH6 as trigger.

   This extends the  Capture support for FMU
   CHAN 5 and 6.
@dagar
Copy link
Member

dagar commented Sep 27, 2018

Module documentation build failure - http://ci.px4.io:8080/blue/organizations/jenkins/PX4%2FFirmware/detail/master_fmu_more_cap_modes/2/pipeline

Warning: undocumented command 'mode_pwm5cap1' in drivers/px4fmu

Warning: undocumented command 'mode_pwm4cap1' in drivers/px4fmu

Copy link
Member

@dagar dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module documentation build failure

@davids5
Copy link
Member Author

davids5 commented Sep 27, 2018

@DanielePettenuzzo fyi:

testing fmu mode_pwm5cap1
FMUv4 - 100,000 Hz on chan 6 (no call out*) from 37.5 % to 62.5 %
FMUv5-mini - 100,000 Hz on chan 6 (no call out*) from 30.5 % to 39.25 %

*you would add your cycle count when the call out is in place for what it adds to the isr.

@davids5
Copy link
Member Author

davids5 commented Sep 27, 2018

@dagar changes pushed. Is CI fail VTOL_tailsitter independant?

@dagar
Copy link
Member

dagar commented Sep 27, 2018

@dagar changes pushed. Is CI fail VTOL_tailsitter independant?

Yes, but it's a very real failure. @RomanBapst FYI

@LorenzMeier
Copy link
Member

Issue filed here for the CI test: #10590

Roman is out of office, so we'll have to rely on Mathieu to get that out of the way most likely.

@LorenzMeier LorenzMeier merged commit d3c37e0 into master Sep 28, 2018
@LorenzMeier LorenzMeier deleted the master_fmu_more_cap_modes branch September 28, 2018 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants