Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] camera trigger: add support for fmu pins 7 and 8 #10857

Closed
wants to merge 1 commit into from
Closed

[WIP] camera trigger: add support for fmu pins 7 and 8 #10857

wants to merge 1 commit into from

Conversation

DanielePettenuzzo
Copy link
Contributor

@DanielePettenuzzo DanielePettenuzzo commented Nov 15, 2018 •
edited by AuterionWrikeBot
Loading

This pr adds support for fmu pwm pins 7 and 8. It was currently just tested on fmu-v5 (Pixhawk 4) for both GPIO and PWM triggering.

@LorenzMeier
Copy link
Member

Awesome! CI doesn’t like it yet

@DanielePettenuzzo
Copy link
Contributor Author

@davids5 In the timer_config.c for fmu-v5 these two timer channels are marked as "need revision". Do you think something is missing?

@DanielePettenuzzo
Copy link
Contributor Author

@LorenzMeier yes I just noticed. I don't have the pwm number in SITL. I will push a fix asap.

@davids5
Copy link
Member

davids5 commented Nov 15, 2018

@davids5 In the timer_config.c for fmu-v5 these two timer channels are marked as "need revision". Do you think something is missing?

@DanielePettenuzzo see #10858

@DanielePettenuzzo
Copy link
Contributor Author

@dagar FYI even before this pr when I build sitl on Mac I get the following messages:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: src/drivers/camera_trigger/libdrivers__camera_trigger.a(pwm.cpp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: src/drivers/camera_trigger/libdrivers__camera_trigger.a(seagull_map2.cpp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: src/drivers/camera_trigger/libdrivers__camera_trigger.a(gpio.cpp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: src/drivers/camera_trigger/libdrivers__camera_trigger.a(pwm.cpp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: src/drivers/camera_trigger/libdrivers__camera_trigger.a(seagull_map2.cpp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: src/drivers/camera_trigger/libdrivers__camera_trigger.a(gpio.cpp.o) has no symbols

@DanielePettenuzzo DanielePettenuzzo force-pushed the camera_trigger_fmu_pins78 branch from dd2edd9 to 5cd181d Compare November 15, 2018 21:23
@DanielePettenuzzo DanielePettenuzzo force-pushed the camera_trigger_fmu_pins78 branch from 5cd181d to 70eb91c Compare November 15, 2018 22:12
@hamishwillee hamishwillee added the Documentation 📑 Anything improving the documentation of the code / ecosystem label Nov 16, 2018
@hamishwillee
Copy link
Contributor

@DanielePettenuzzo This has a docs implication. Can you make it clear what will need to happen in this section of the camera trigger doc? (ideally create PR for it and I can edit as needed).

@DanielePettenuzzo
Copy link
Contributor Author

DanielePettenuzzo commented Nov 16, 2018 •
edited
Loading

@hamishwillee yes I need to create a new camera capture section and update the camera trigger. Camera capture pr: #10295

@stale
Copy link

stale bot commented Feb 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@hamishwillee
Copy link
Contributor

@DanielePettenuzzo What's happening with this?

@stale stale bot removed the Admin: Wont fix label Feb 14, 2019
@hamishwillee
Copy link
Contributor

Ping @DanielePettenuzzo

@DanielePettenuzzo
Copy link
Contributor Author

@hamishwillee sorry for the late reply. I will document all the new things that were added with the camera capture pr and with this one. I need to rebase and test this pr again. I will probably be able to update the documentation some time this week.

@hamishwillee
Copy link
Contributor

@DanielePettenuzzo Awesome, thank you. I will be away on holiday for 3 weeks. Can you please CC in @bkueng to your docs PR for review?

@weekly-digest weekly-digest bot mentioned this pull request Jul 14, 2019
Closed
@stale stale bot closed this Jul 24, 2019
@hamishwillee
Copy link
Contributor

@DanielePettenuzzo This PR was useful. Were you really intending to allow it to lapse?

@hamishwillee hamishwillee reopened this Jul 25, 2019
@stale stale bot removed the Admin: Wont fix label Jul 25, 2019
@PX4 PX4 deleted a comment from stale bot Jul 25, 2019
@PX4 PX4 deleted a comment from stale bot Jul 25, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jul 28, 2019
Closed
@DanielePettenuzzo
Copy link
Contributor Author

@hamishwillee sorry I was on holiday and totally missed this one. No I should rebase and test it again. @RomanBapst if we plan on doing some mapping with the seagull in the near future we can test this in flight

@stale
Copy link

stale bot commented Oct 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 27, 2019
@bys1123
Copy link
Contributor

bys1123 commented Jun 15, 2020 •
edited
Loading

@dagar I saw few users they want to use Generic Quadplane VTOL with camera trigger out of box, this frame already use AUX1~5, so they choose to buy Pixhawk4 which have AUX1~8, but camera trigger seems would not work with AUX 78 yet.

@stale stale bot removed the stale label Jun 15, 2020
@saengphet
Copy link

@dagar I saw few users they want to use Generic Quadplane VTOL with camera trigger out of box, this frame already use AUX15, so they choose to buy Pixhawk4 which have AUX18, but camera trigger seems would not work with AUX 78 yet.

I agree with you. In my case, I have to set a new main and aux mixer to empty aux pin 5 and 6. It would be great if pin 7 and 8 could be assigned as a camera trigger pin.

@dagar
Copy link
Member

dagar commented Jun 15, 2020

@bys1123 @saengphet thanks for the update. Let's figure out a way to make it as configurable as it needs to be across different boards.

@dagar dagar self-requested a review June 15, 2020 18:52
@dagar dagar self-assigned this Jun 15, 2020
@dagar dagar added this to the Release v1.12.0 milestone Jun 15, 2020
@bkueng bkueng mentioned this pull request Aug 4, 2020
Merged
@bkueng
Copy link
Member

bkueng commented Aug 4, 2020

Done in #15482

@bkueng bkueng closed this Aug 4, 2020
@bkueng bkueng deleted the camera_trigger_fmu_pins78 branch August 4, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar Awaiting requested review from dagar

Assignees

@dagar dagar

Labels
Admin: Enhancement (improvement) 💡 Documentation 📑 Anything improving the documentation of the code / ecosystem
Projects
None yet
Milestone
Release v1.12.0
Development

Successfully merging this pull request may close these issues.
8 participants
@DanielePettenuzzo @LorenzMeier @davids5 @hamishwillee @bys1123 @saengphet @dagar @bkueng