Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr add ground effect deadzone #10950

Closed

Conversation

EliaTarasov
Copy link
Contributor

@EliaTarasov EliaTarasov commented Nov 29, 2018

  • Adds the ability to enable/disable support for baro deadzone near ground.
  • Adds default range for baro deadzone.

@priseborough
Copy link
Contributor

Please provide a link to a log where you have tested this.

Copy link
Contributor

@priseborough priseborough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The major problem with this is that it turns on ground effect compensation permanently when the parameter is set. This is not desirable because it can lead to significant height errors during normal flying. It should only be turned on for takeoff or when landing is expected. This should be done by the commander module.

When this has been done, please submit with test evidence that shows the feature working during landing and takeoff.

@@ -336,6 +336,10 @@ class Ekf2 final : public ModuleBase<Ekf2>, public ModuleParams
(ParamExtFloat<px4::params::EKF2_BARO_NOISE>) _baro_noise, ///< observation noise for barometric height fusion (m)
(ParamExtFloat<px4::params::EKF2_BARO_GATE>)
_baro_innov_gate, ///< barometric height innovation consistency gate size (STD)
(ParamInt<px4::params::EKF2_GND_EFF_EN>)
_enableGndEff, ///< Controls barometric deadzone fusion, 0 disables, 1 enables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snake_case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhkabir thanks!
@priseborough

The major problem with this is that it turns on ground effect compensation permanently when the parameter is set. This is not desirable because it can lead to significant height errors during normal flying. It should only be turned on for takeoff or when landing is expected. This should be done by the commander module.

Agree. But this feature should work in ALT/POS_CTL too. How to define if the landing is expected in these modes?
Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhkabir could you please give a hint?

It should only be turned on for takeoff or when landing is expected.

How to define if the landing is expected in ALT_CTL/POS_CTL modes when only baro is used for height estimation?

This should be done by the commander module.

I looked into commander module but didn't find much about.

@EliaTarasov EliaTarasov force-pushed the pr-addGroundEffectDeadzone branch from 742606d to 7e793fe Compare December 3, 2018 08:44
@EliaTarasov EliaTarasov closed this Jan 4, 2019
@RomanBapst
Copy link
Contributor

@priseborough @EliaTarasov I have implemented something similar and would like to bring it upstream.
I have extended the land detector to publish a flag called "in_ground_effect". The logic for that is quite simple but it basically checks if the vehicle is not moving horizontally and descending close to land speed.
The reason I added this to the land detector is because pretty much all of this logic is already in there. Of course you will always be able to fool the system since descending at landing speed would trigger the flag even if the vehicle is still far from the ground. Once could maybe add a bit more logic which does not trigger the flag if the vehicle is descending a lot faster than landing speed (assuming the user does not land by slamming the vehicle into the ground).

I think something that is missing additionally is the ability to use the terrain estimate to activate the baro innovation deadzone.

@EliaTarasov EliaTarasov deleted the pr-addGroundEffectDeadzone branch July 7, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants