-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr add ground effect deadzone #10950
Conversation
EliaTarasov
commented
Nov 29, 2018
•
edited by AuterionWrikeBot
Loading
edited by AuterionWrikeBot
- Adds the ability to enable/disable support for baro deadzone near ground.
- Adds default range for baro deadzone.
276d518
to
742606d
Compare
Please provide a link to a log where you have tested this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The major problem with this is that it turns on ground effect compensation permanently when the parameter is set. This is not desirable because it can lead to significant height errors during normal flying. It should only be turned on for takeoff or when landing is expected. This should be done by the commander module.
When this has been done, please submit with test evidence that shows the feature working during landing and takeoff.
src/modules/ekf2/ekf2_main.cpp
Outdated
@@ -336,6 +336,10 @@ class Ekf2 final : public ModuleBase<Ekf2>, public ModuleParams | |||
(ParamExtFloat<px4::params::EKF2_BARO_NOISE>) _baro_noise, ///< observation noise for barometric height fusion (m) | |||
(ParamExtFloat<px4::params::EKF2_BARO_GATE>) | |||
_baro_innov_gate, ///< barometric height innovation consistency gate size (STD) | |||
(ParamInt<px4::params::EKF2_GND_EFF_EN>) | |||
_enableGndEff, ///< Controls barometric deadzone fusion, 0 disables, 1 enables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snake_case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhkabir thanks!
@priseborough
The major problem with this is that it turns on ground effect compensation permanently when the parameter is set. This is not desirable because it can lead to significant height errors during normal flying. It should only be turned on for takeoff or when landing is expected. This should be done by the commander module.
Agree. But this feature should work in ALT/POS_CTL too. How to define if the landing is expected in these modes?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhkabir could you please give a hint?
It should only be turned on for takeoff or when landing is expected.
How to define if the landing is expected in ALT_CTL/POS_CTL modes when only baro is used for height estimation?
This should be done by the commander module.
I looked into commander
module but didn't find much about.
742606d
to
7e793fe
Compare
@priseborough @EliaTarasov I have implemented something similar and would like to bring it upstream. I think something that is missing additionally is the ability to use the terrain estimate to activate the baro innovation deadzone. |