param command updates (change show default and add status) #11200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-param_cmd
branch
2 times, most recently
from
d0aee88 to
540f577
Compare
bkueng
reviewed
Jan 14, 2019
|
|
||
| const hrt_abstime rate_limit = 2000 * 1000; // rate-limit saving to 2 seconds | ||
| hrt_abstime last_save_elapsed = hrt_elapsed_time(&last_autosave_timestamp); | ||
| static constexpr const hrt_abstime rate_limit = 2_s; // rate-limit saving to 2 seconds |
There was a problem hiding this comment.
static constexpr const is a bit too much here, no? Does it actually make a difference?
There was a problem hiding this comment.
Ha, in this case it almost certainly not, but I guess the point would be that it's never going to be worse to make something a compile time constant.
There was a problem hiding this comment.
True, I was just thinking that it hurts readability a bit.
|
This will likely have to wait until after #11013 for more flash on fmu-v2. |
bkueng
previously approved these changes
Jan 15, 2019
|
|
||
| const hrt_abstime rate_limit = 2000 * 1000; // rate-limit saving to 2 seconds | ||
| hrt_abstime last_save_elapsed = hrt_elapsed_time(&last_autosave_timestamp); | ||
| static constexpr const hrt_abstime rate_limit = 2_s; // rate-limit saving to 2 seconds |
There was a problem hiding this comment.
True, I was just thinking that it hurts readability a bit.
- add -a option to display all possible system parameters
|
Rebase on master (should fit in px4_fmu-v2 now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR contains 2 changes to the param command.
param statusto print status of the param system (current file, memory usage, perf counters)Example
nsh> param status INFO [parameters] summary: 638/1241 (used/total) INFO [parameters] file: /fs/mtd_params INFO [parameters] storage array: 22/32 elements (512 bytes total) INFO [parameters] auto save: on INFO [parameters] last auto save: 3.109 seconds ago param_export: 4 events, 17386us elapsed, 4346.50us avg, min 3598us max 5006us 577.939us rms param_find: 786 events, 7474us elapsed, 9.51us avg, min 3us max 413us 25.181us rms param_get: 14164 events, 94875us elapsed, 6.70us avg, min 3us max 1994us 36.532us rms param_set: 23 events, 347us elapsed, 15.09us avg, min 5us max 27us 6.536us rms