Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoSmoothVel - Handle NAN in velocity and position properly #11233

Merged
merged 1 commit into from
Jan 17, 2019
Merged

AutoSmoothVel - Handle NAN in velocity and position properly #11233

merged 1 commit into from
Jan 17, 2019

Conversation

bresch
Copy link
Member

@bresch bresch commented Jan 17, 2019 •
edited by AuterionWrikeBot
Loading

fixes #11197

Instead of transmitting the NANs when the position_setpoint and the velocity_setpoint are both NAN, the _prepareSetpoint() function was forcing the velocity_setpoint to 0. This produced an undesired behavior when the mode was set to hold.

@bresch bresch requested a review from julianoes January 17, 2019 16:04
@LorenzMeier LorenzMeier merged commit a2e9d9f into master Jan 17, 2019
@LorenzMeier LorenzMeier deleted the nan-traj branch January 17, 2019 16:55
@LorenzMeier
Copy link
Member

Awesome!

@julianoes
Copy link
Contributor

Thanks @bresch!

@weekly-digest weekly-digest bot mentioned this pull request Jan 19, 2019
Closed
@Stifael Stifael mentioned this pull request Jan 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzMeier LorenzMeier LorenzMeier approved these changes

@julianoes julianoes Awaiting requested review from julianoes

Assignees
No one assigned
Labels
bug Multirotor 🛸
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multicopter takes off in HOLD on ground
3 participants
@bresch @LorenzMeier @julianoes