-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posix shutdown investigation/hacks [take 2] #11654
Conversation
We should not be calling system_exit because it doesn't allow the threads to clean up properly.
We should try to let threads exit cleanly.
This should eventually by done using ModuleBase but for now this should fix testing and shutting down the system.
@dagar I don't understand the path for this |
Nice, thanks @julianoes! and @dagar for starting out 👍
|
@MaEtUgR hm, so why did Ctrl+C work for me on Windows (Cygwin)? |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
We should have got this in before it had that many conflicts... @julianoes any plans to rebase (without any pressure)? |
@MaEtUgR yes we should get this in 😄 but it's far down my list. |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Impossible to rebase, closing. |
This PR is on top of #11525.
For me Ctrl+C and
shutdown
work on both Linux and Windows. Please cross-test and review.I tried to get rid of all
pthread_cancel
so that one workaround in the lockstep scheduler can removed:https://github.com/PX4/Firmware/blob/2ebb9d2ab52bce56a74d34d3b36c7130422577c2/platforms/posix/src/lockstep_scheduler/include/lockstep_scheduler/lockstep_scheduler.h#L24-L34