Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posix shutdown investigation/hacks [take 2] #11654

Closed
wants to merge 7 commits into from

Conversation

julianoes
Copy link
Contributor

@julianoes julianoes commented Mar 15, 2019

This PR is on top of #11525.

For me Ctrl+C and shutdown work on both Linux and Windows. Please cross-test and review.

I tried to get rid of all pthread_cancel so that one workaround in the lockstep scheduler can removed:
https://github.com/PX4/Firmware/blob/2ebb9d2ab52bce56a74d34d3b36c7130422577c2/platforms/posix/src/lockstep_scheduler/include/lockstep_scheduler/lockstep_scheduler.h#L24-L34

dagar and others added 3 commits March 15, 2019 12:03
We should not be calling system_exit because it doesn't allow the
threads to clean up properly.
We should try to let threads exit cleanly.
@julianoes julianoes requested review from dagar, bkueng and MaEtUgR March 15, 2019 12:02
This should eventually by done using ModuleBase but for now this should
fix testing and shutting down the system.
@julianoes
Copy link
Contributor Author

@dagar I don't understand the path for this dyn test. It now works locally but still seems to fail for appveyor! 😞

@MaEtUgR
Copy link
Member

MaEtUgR commented Mar 15, 2019

Nice, thanks @julianoes! and @dagar for starting out 👍

@julianoes
Copy link
Contributor Author

@MaEtUgR hm, so why did Ctrl+C work for me on Windows (Cygwin)?

@MaEtUgR
Copy link
Member

MaEtUgR commented Mar 21, 2019

@MaEtUgR hm, so why did Ctrl+C work for me on Windows (Cygwin)?

Ctrl+C still works because of the lines I added in #11305 and referenced above. This pr is fine and fixes the shutdown command but just does not yet allow to remove the hotfix for Ctrl+C.

@stale
Copy link

stale bot commented Oct 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@MaEtUgR
Copy link
Member

MaEtUgR commented Oct 21, 2019

We should have got this in before it had that many conflicts... @julianoes any plans to rebase (without any pressure)?

@julianoes
Copy link
Contributor Author

@MaEtUgR yes we should get this in 😄 but it's far down my list.

@stale
Copy link

stale bot commented Jan 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@julianoes julianoes marked this pull request as draft June 2, 2020 11:28
@stale stale bot removed the stale label Jun 2, 2020
@stale
Copy link

stale bot commented Aug 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Aug 31, 2020
@julianoes
Copy link
Contributor Author

Impossible to rebase, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants