Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode minor settings update #11978

Merged
merged 1 commit into from
May 6, 2019
Merged

vscode minor settings update #11978

merged 1 commit into from
May 6, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented May 6, 2019

A few minor vscode settings I've found to be useful (without being too opinionated).

  • minimap size and display
  • title bar show file path and modified
  • disable natural language search (sends keystrokes to Bing)

Screenshot from 2019-05-06 15-54-25

 - minimap size and display
 - title bar show file and modified
 - disable natural language search (sends keystrokes to Bing)
@LorenzMeier
Copy link
Member

I've moved to it as well (from Sublime).

@dagar
Copy link
Member Author

dagar commented May 6, 2019

We might need a bit of documentation. The only additional thing you really have to do is install the recommended extensions (cmake, cpp, etc).

  1. Pop up (bottom right) to install recommended extensions the first time you open Firmware.
    Screenshot from 2019-05-06 16-06-37

  2. Workspace recommended extensions automatically installed.
    Screenshot from 2019-05-06 16-06-53

  3. Select cmake config from GUI.
    Screenshot from 2019-05-06 16-10-01

@dagar dagar merged commit 72b898f into PX4:master May 6, 2019
@dagar dagar deleted the pr-vscode_minor branch May 6, 2019 20:37
@hamishwillee
Copy link
Contributor

We might need a bit of documentation.

I think we are far enough along for that. Will add first draft of something today.

@hamishwillee
Copy link
Contributor

@dagar Played with this a bit today. Some questions:

  1. Does/should this work with the Cygwin build on Windows. I tried to debug SITL and got:
    image
    ... I assume not, but I could be driving this wrong.
  2. To add PX4 to vscode, do I just add the Firmware directory? (this works, but wondered if it was "right way":
    image
  3. Do I say yes to all suggested extensions?
  4. Is there any reason not to sync vscode to github?
  5. I'm asked on Ubuntu 1.18 if I want to download new version of cmake - does it matter?
    image
  6. There was a dialog cmake kit detect. I selected PX4 detect option - that OK?
  7. In third image you say "Select cmake config from GUI". I can't see anything selected - are you actually suggesting I do the following:
    image
  8. Once I do that I can do debugging as shown.
    image
  9. Anything much other than the above you'd like to explain about this in docs. If so, what?

@dagar
Copy link
Member Author

dagar commented May 7, 2019

  1. Yes I could see it working with cygwin, but I'd be very surprised if it worked properly as is. I've only used it on Linux and MacOS so far.
  2. I simply do "Open Folder", but adding to workspace should also work (I'll check).
  3. Yes!
  4. I'm not sure what you're referring to. Git sync or vscode settings sync? The PX4/Firmware settings are here. https://github.com/PX4/Firmware/blob/master/.vscode/settings.json
  5. Our exact cmake version dependency isn't known, but you should be fine on recent Ubuntu. The suggestion to install the latest cmake is coming from the cmake plugin, not a PX4 requirement.
  6. Yes, these are basically cmake Toolchains, but PX4 handles that all internally. I could see a cygwin option in here in the future.
  7. Do you the config line on the bottom bar? These are "cmake variants" built into the PX4/Firmware vscode config that correspond to PX4 configs.
    Screenshot from 2019-05-07 08-34-53
  8. One caveat here is that the debug option will only work if you've loaded that config. I haven't found a way to limit the selection yet.
  9. Not really, I just want it to be as easy as possible for someone to get into a position they can effectively do everything from the GUI. Once working within vscode where they've built the source there's code completion, including generated things like uORB messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants