Allow the mavlink sysid of GCS to be the same as MAV_SYS_ID #11998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from upstream
- It now works even if SYSID of GCS is the same as MAV_SYS_ID.
jdzerve
changed the title
|
The system ID of drone and ground control station need to be different (system == vehicle). So I believe this change is not correct. Please feel free to re-open if I didn't understand the intent correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PX4 is ignoring heartbeats from groundstation if mavlink sysid of groundstation is the same as MAV_SYS_ID. That leads to failsafe on datalink loss to kick in.
This PR removes the offending condition in MavlinkReceiver::handle_message_heartbeat