Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code: remove matter of taste tabs customization #12058

Merged
merged 1 commit into from
May 24, 2019

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented May 23, 2019

Describe problem solved by the proposed pull request
There is a lot of very useful project specific configuration contributed by @dagar in the .vscode folder for the PX4 repo. But this setting is a matter of taste changing the UI behavior for the editor and not project specific. It determines if new code tabs are kept open when you just take a quick glance without changing anything. Since this feature is default and I like it a lot I would prefer to not have it disabled for PX4 by workspace settings.

Note: When you want to keep a tab that is in preview mode open you can double click to open it, double click on the tab name or press Ctrl+K followed by Enter.

Test data / coverage
Without these lines it runs again like expected.

Describe your preferred solution
Can we have matter of taste settings kept in our local user configuration?

@MaEtUgR MaEtUgR requested a review from dagar May 23, 2019 20:04
@MaEtUgR MaEtUgR self-assigned this May 23, 2019
@dagar
Copy link
Member

dagar commented May 24, 2019

This is good, it means it's actually being used.

I think the rule here can be simple. If there's a difference in personal preference like this on settings that don't impact PX4 specifically we leave it as default. VSCode already has mechanisms to override these settings per user, per folder, per project.

Thanks @MaEtUgR

@dagar dagar merged commit 6eb29fc into master May 24, 2019
@dagar dagar deleted the vscode-allow-tabs-review branch May 24, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants