MC PositionControl - Explicitly convert tilt to radians #12328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Jun 25, 2019
…ents instead of converting the variable holding the parameter
|
@dagar Good to merge now |
dagar
approved these changes
Jun 27, 2019
|
Thank you, that's much easier on the eyes. |
|
Backported for v1.9.2. 220f5cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion of the tilt parameters from degrees to radians was done by updating the variables containing the value of the parameters:
_param_mpc_man_tilt_maxand_param_mpc_tiltmax_air. IMO, those variables should only be changed when the intent is to update a parameter (e.g.: clamp a value) and not for scaling.follows #12324